Commit4d54543

committed

Fix upper limit for vacuum_cleanup_index_scale_factor

6ca33a8 sets upper limit for vacuum_cleanup_index_scale_factor toDBL_MAX. DBL_MAX appears to be platform-dependent. That causesmany buildfarm animals to fail, because we check boundaries ofvacuum_cleanup_index_scale_factor in regression tests.This commit changes upper limit from DBL_MAX to just "large enough"limit, which was arbitrary selected as 1e10.Author: Alexander KorotkovReported-by: Tom Lane, Darafei PraliaskouskiDiscussion:https://postgr.es/m/CAPpHfdvewmr4PcpRjrkstoNn1n2_6dL-iHRB21CCfZ0efZdBTg%40mail.gmail.comDiscussion:https://postgr.es/m/CAC8Q8tLYFOpKNaPS_E7V8KtPdE%3D_TnAn16t%3DA3LuL%3DXjfOO-BQ%40mail.gmail.com

1 parenta89357e commit4d54543Copy full SHA for 4d54543

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6989,7 +6989,8 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;`
`6989`	`6989`	`</para>`
`6990`	`6990`
`6991`	`6991`	`<para>`
`6992`		`- The value should be non-negative.`
	`6992`	`+ The value can range from <literal>0</literal> to`
	`6993`	`+ <literal>10000000000</literal>.`
`6993`	`6994`	`When <varname>vacuum_cleanup_index_scale_factor</varname> is set to`
`6994`	`6995`	`<literal>0</literal>, index scans are never skipped during`
`6995`	`6996`	`<command>VACUUM</command> cleanup. The default value is <literal>0.1</literal>.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ static relopt_real realRelOpts[] =`
`416`	`416`	`RELOPT_KIND_BTREE,`
`417`	`417`	`ShareUpdateExclusiveLock`
`418`	`418`	`},`
`419`		`--1,0.0,DBL_MAX`
	`419`	`+-1,0.0,1e10`
`420`	`420`	`},`
`421`	`421`	`/* list terminator */`
`422`	`422`	`{{NULL}}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3253,7 +3253,7 @@ static struct config_real ConfigureNamesReal[] =`
`3253`	`3253`	`NULL`
`3254`	`3254`	`},`
`3255`	`3255`	`&vacuum_cleanup_index_scale_factor,`
`3256`		`-0.1,0.0,DBL_MAX,`
	`3256`	`+0.1,0.0,1e10,`
`3257`	`3257`	`NULL,NULL,NULL`
`3258`	`3258`	`},`
`3259`	`3259`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ select reloptions from pg_class WHERE oid = 'btree_idx1'::regclass;`
`165`	`165`	`-- Fail while setting improper values`
`166`	`166`	`create index btree_idx_err on btree_test(a) with (vacuum_cleanup_index_scale_factor = -10.0);`
`167`	`167`	`ERROR: value -10.0 out of bounds for option "vacuum_cleanup_index_scale_factor"`
`168`		`-DETAIL: Valid values are between "0.000000" and "179769313486231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368.000000".`
	`168`	`+DETAIL: Valid values are between "0.000000" and "10000000000.000000".`
`169`	`169`	`create index btree_idx_err on btree_test(a) with (vacuum_cleanup_index_scale_factor = 100.0);`
`170`	`170`	`create index btree_idx_err on btree_test(a) with (vacuum_cleanup_index_scale_factor = 'string');`
`171`	`171`	`ERROR: invalid value for floating point option "vacuum_cleanup_index_scale_factor": string`

Comments

(0)