Commit499faf9

committed

smgr: Make SMgrRelation initialization safer against errors

In case the smgr_open callback failed, the ->pincount field would not beinitialized and the relation would not be put onto the unpinned_relns list.This buglet was introduced in21d9c3e, in 17.Discussion:https://postgr.es/m/3vae7l5ozvqtxmd7rr7zaeq3qkuipz365u3rtim5t5wdkr6f4g@vkgf2fogjirlBackpatch-through: 17

1 parent62d712e commit499faf9Copy full SHA for 499faf9

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -234,12 +234,12 @@ smgropen(RelFileLocator rlocator, ProcNumber backend)`
`234`	`234`	`reln->smgr_cached_nblocks[i]=InvalidBlockNumber;`
`235`	`235`	`reln->smgr_which=0;/* we only have md.c at present */`
`236`	`236`
`237`		`-/* implementation-specific initialization */`
`238`		`-smgrsw[reln->smgr_which].smgr_open(reln);`
`239`		`-`
`240`	`237`	`/* it is not pinned yet */`
`241`	`238`	`reln->pincount=0;`
`242`	`239`	`dlist_push_tail(&unpinned_relns,&reln->node);`
	`240`	`+`
	`241`	`+/* implementation-specific initialization */`
	`242`	`+smgrsw[reln->smgr_which].smgr_open(reln);`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`returnreln;`

Comments

(0)