NotificationsYou must be signed in to change notification settings
Fork5k
Star18.1k

Commit48c2c7b

committed

pg_dumpall: Skip global objects with --statistics-only or --no-schema.

Previously, pg_dumpall would still dump global objects such as rolesand tablespaces even when --statistics-only or --no-schema was specified.Since these global objects are treated as schema-level data, they shouldbe skipped in these cases.This commit fixes the issue by ensuring that global objects are notdumped when either --statistics-only or --no-schema is used.Author: Fujii Masao <masao.fujii@oss.nttdata.com>Reviewed-by: Corey Huinker <corey.huinker@gmail.com>Discussion:https://postgr.es/m/08129593-6f3c-4fb9-94b7-5aa2eefb99b0@oss.nttdata.comBackpatch-through: 18

1 parentecc5161 commit48c2c7bCopy full SHA for 48c2c7b

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dumpall.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dumpall.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ main(int argc, char *argv[])`
`632`	`632`	`fprintf(OPF,"SET escape_string_warning = off;\n");`
`633`	`633`	`fprintf(OPF,"\n");`
`634`	`634`
`635`		`-if (!data_only)`
	`635`	`+if (!data_only&& !statistics_only&& !no_schema)`
`636`	`636`	`{`
`637`	`637`	`/*`
`638`	`638`	`* If asked to --clean, do that first. We can avoid detailed`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit48c2c7b

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dumpall.c`

0 commit comments