NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.8k

Commit47169c2

committed

Avoid possible regression test instability in timestamp.sql.

Concurrent autovacuum could result in a change in the order of thelive rows in timestamp_tbl. While this would not happen with thedefault autovacuum parameters, it's fairly easy to hit ifautovacuum_vacuum_threshold is made small enough to allow autovacto decide to process this table. That's a stumbling block for tryingto exercise autovacuum aggressively using the core regression tests.To fix, replace an unqualified DELETE with a TRUNCATE. There's asimilar DELETE just above (and no order-sensitive queries between),so this doesn't lose any test coverage and might indeed be arguedto improve it.Discussion:https://postgr.es/m/17428.1555348950@sss.pgh.pa.us

1 parent1e87198 commit47169c2Copy full SHA for 47169c2

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - timestamp.out
- sql
  - timestamp.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/timestamp.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ SELECT count(*) AS two FROM TIMESTAMP_TBL WHERE d1 = timestamp(2) without time z`
`74`	`74`	`(1 row)`
`75`	`75`
`76`	`76`	`COMMIT;`
`77`		`-DELETE FROM TIMESTAMP_TBL;`
	`77`	`+TRUNCATE TIMESTAMP_TBL;`
`78`	`78`	`-- Special values`
`79`	`79`	`INSERT INTO TIMESTAMP_TBL VALUES ('-infinity');`
`80`	`80`	`INSERT INTO TIMESTAMP_TBL VALUES ('infinity');`

`‎src/test/regress/sql/timestamp.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ SELECT pg_sleep(0.1);`
`44`	`44`	`SELECTcount(*)AS twoFROM TIMESTAMP_TBLWHERE d1=timestamp(2) without time zone'now';`
`45`	`45`	`COMMIT;`
`46`	`46`
`47`		`-DELETEFROM TIMESTAMP_TBL;`
	`47`	`+TRUNCATE TIMESTAMP_TBL;`
`48`	`48`
`49`	`49`	`-- Special values`
`50`	`50`	`INSERT INTO TIMESTAMP_TBLVALUES ('-infinity');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit47169c2

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/timestamp.out`

`‎src/test/regress/sql/timestamp.sql`

0 commit comments