Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3f190f6

Browse files
committed
Fix table_rewrite event trigger for ALTER TYPE/SET DATA TYPE CASCADE
When a composite type being used in a typed table is modified by wayof ALTER TYPE, a table rewrite occurs appearing to come from ALTER TYPE.The existing event_trigger.c code was unable to cope with thatand raised a spurious error. The fix is just to accept that commandtag for the event, and document this properly.Noted while fooling with deparsing of DDL commands. This appears to bean oversight in commit618c943.Thanks to Mark Wong for documentation wording help.
1 parentbda76c1 commit3f190f6

File tree

4 files changed

+27
-6
lines changed

4 files changed

+27
-6
lines changed

‎doc/src/sgml/event-trigger.sgml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,11 @@
6868

6969
<para>
7070
The <literal>table_rewrite</> event occurs just before a table is
71-
rewritten by the command <literal>ALTER TABLE</literal>. While other
71+
rewritten by some actions of the commands <literal>ALTER TABLE</> and
72+
<literal>ALTER TYPE</>. While other
7273
control statements are available to rewrite a table,
7374
like <literal>CLUSTER</literal> and <literal>VACUUM</literal>,
74-
the <literal>table_rewrite</> event is currently only triggered by
75-
the <literal>ALTER TABLE</literal> command, and only when that command
76-
attempts to rewrite the table.
75+
the <literal>table_rewrite</> event is not triggered by them.
7776
</para>
7877

7978
<para>
@@ -318,7 +317,7 @@
318317
<entry align="center"><literal>X</literal></entry>
319318
<entry align="center"><literal>X</literal></entry>
320319
<entry align="center"><literal>-</literal></entry>
321-
<entry align="center"><literal>-</literal></entry>
320+
<entry align="center"><literal>X</literal></entry>
322321
<entry align="center"></entry>
323322
</row>
324323
<row>

‎src/backend/commands/event_trigger.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,8 @@ validate_table_rewrite_tags(const char *filtervar, List *taglist)
326326
staticevent_trigger_command_tag_check_result
327327
check_table_rewrite_ddl_tag(constchar*tag)
328328
{
329-
if (pg_strcasecmp(tag,"ALTER TABLE")==0)
329+
if (pg_strcasecmp(tag,"ALTER TABLE")==0||
330+
pg_strcasecmp(tag,"ALTER TYPE")==0)
330331
returnEVENT_TRIGGER_COMMAND_TAG_OK;
331332

332333
returnEVENT_TRIGGER_COMMAND_TAG_NOT_SUPPORTED;

‎src/test/regress/expected/event_trigger.out

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,17 @@ alter table rewriteme
370370
NOTICE: Table 'rewriteme' is being rewritten (reason = 6)
371371
-- shouldn't trigger a table_rewrite event
372372
alter table rewriteme alter column foo type numeric(12,4);
373+
-- typed tables are rewritten when their type changes
374+
create type rewritetype as (a int);
375+
create table rewritemetoo1 of rewritetype;
376+
create table rewritemetoo2 of rewritetype;
377+
alter type rewritetype alter attribute a type text cascade;
378+
NOTICE: Table 'rewritemetoo1' is being rewritten (reason = 4)
379+
NOTICE: Table 'rewritemetoo2' is being rewritten (reason = 4)
380+
-- but this doesn't work
381+
create table rewritemetoo3 (a rewritetype);
382+
alter type rewritetype alter attribute a type varchar cascade;
383+
ERROR: cannot alter type "rewritetype" because column "rewritemetoo3.a" uses it
373384
drop table rewriteme;
374385
drop event trigger no_rewrite_allowed;
375386
drop function test_evtrig_no_rewrite();

‎src/test/regress/sql/event_trigger.sql

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,16 @@ alter table rewriteme
276276
-- shouldn't trigger a table_rewrite event
277277
altertable rewriteme alter column foo typenumeric(12,4);
278278

279+
-- typed tables are rewritten when their type changes
280+
createtyperewritetypeas (aint);
281+
createtablerewritemetoo1 of rewritetype;
282+
createtablerewritemetoo2 of rewritetype;
283+
altertype rewritetype alter attribute a typetext cascade;
284+
285+
-- but this doesn't work
286+
createtablerewritemetoo3 (a rewritetype);
287+
altertype rewritetype alter attribute a typevarchar cascade;
288+
279289
droptable rewriteme;
280290
drop event trigger no_rewrite_allowed;
281291
dropfunction test_evtrig_no_rewrite();

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp