Commit3f06324

committed

Fix memory leak in pg_restore with zstd-compressed data.

EndCompressorZstd() neglected to free everything. This wasmost visible with a lot of large objects in the dump.Per report from Tomasz Szypowski. Back-patch to v16where this code came in.Discussion:https://postgr.es/m/DU0PR04MB94193D038A128EF989F922D199042@DU0PR04MB9419.eurprd04.prod.outlook.com

1 parentd96d1d5 commit3f06324Copy full SHA for 3f06324

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -137,9 +137,10 @@ EndCompressorZstd(ArchiveHandle AH, CompressorState cs)`
`137`	`137`	`Assert(zstdcs->dstream==NULL);`
`138`	`138`	`_ZstdWriteCommon(AH,cs, true);`
`139`	`139`	`ZSTD_freeCStream(zstdcs->cstream);`
`140`		`-pg_free(zstdcs->output.dst);`
`141`	`140`	`}`
`142`	`141`
	`142`	`+/* output buffer may be allocated in either mode */`
	`143`	`+pg_free(zstdcs->output.dst);`
`143`	`144`	`pg_free(zstdcs);`
`144`	`145`	`}`
`145`	`146`

Comments

(0)