NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit3f02b51

Amit Kapila

committed

Match the buffer usage tracking for leader and worker backends.

In the leader backend, we don't track the buffer usage for ExecutorStartphase whereas in worker backend we track it for ExecutorStart phase aswell. This leads to different value for buffer usage stats for theparallel and non-parallel query. Change the code so that worker backendalso starts tracking buffer usage after ExecutorStart.Author: Amit Kapila and Robert HaasReviewed-by: Robert Haas and Andres FreundBackpatch-through: 9.6 where this code was introducedDiscussion:https://postgr.es/m/86137f17-1dfb-42f9-7421-82fd786b04a1@anayrat.info

1 parent71e3b28 commit3f02b51Copy full SHA for 3f02b51

File tree

1 file changed

-3

lines changed

src/backend/executor
- execParallel.c

1 file changed

-3

lines changed

`‎src/backend/executor/execParallel.c`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -979,9 +979,6 @@ ParallelQueryMain(dsm_segment seg, shm_toc toc)`
`979`	`979`	`/* Report workers' query for monitoring purposes */`
`980`	`980`	`pgstat_report_activity(STATE_RUNNING,debug_query_string);`
`981`	`981`
`982`		`-/* Prepare to track buffer usage during query execution. */`
`983`		`-InstrStartParallelQuery();`
`984`		`-`
`985`	`982`	`/* Attach to the dynamic shared memory area. */`
`986`	`983`	`area_space=shm_toc_lookup(toc,PARALLEL_KEY_DSA, false);`
`987`	`984`	`area=dsa_attach_in_place(area_space,seg);`
`@@ -993,6 +990,15 @@ ParallelQueryMain(dsm_segment seg, shm_toc toc)`
`993`	`990`	`queryDesc->planstate->state->es_query_dsa=area;`
`994`	`991`	`ExecParallelInitializeWorker(queryDesc->planstate,toc);`
`995`	`992`
	`993`	`+/*`
	`994`	`+ * Prepare to track buffer usage during query execution.`
	`995`	`+ *`
	`996`	`+ * We do this after starting up the executor to match what happens in the`
	`997`	`+ * leader, which also doesn't count buffer accesses that occur during`
	`998`	`+ * executor startup.`
	`999`	`+ */`
	`1000`	`+InstrStartParallelQuery();`
	`1001`	`+`
`996`	`1002`	`/* Run the plan */`
`997`	`1003`	`ExecutorRun(queryDesc,ForwardScanDirection,0L, true);`
`998`	`1004`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3f02b51

File tree

1 file changed

1 file changed

`‎src/backend/executor/execParallel.c`

0 commit comments