NotificationsYou must be signed in to change notification settings
Fork5.3k
Star19.2k

Commit3df4df5

Amit Kapila

committed

Fix a BF failure caused by commit76b7872.

The issue occurred because the replication slot was not released in theslotsync worker when a slot synchronization cycle was skipped. This skiphappened because the required WAL was not received and flushed on thestandby server. As a result, in the next cycle, when attempting to acquirethe slot, an assertion failure was triggered.Author: Hou Zhijie <houzj.fnst@fujitsu.com>Discussion:https://postgr.es/m/CAA4eK1KMwYUYy=oAVHu9mam+vX50ixxfhO4_C=kgQC8VCQHEfw@mail.gmail.com

1 parent76b7872 commit3df4df5Copy full SHA for 3df4df5

File tree

1 file changed

-0

lines changed

src/backend/replication/logical
- slotsync.c

1 file changed

-0

lines changed

`‎src/backend/replication/logical/slotsync.c‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,8 @@ synchronize_one_slot(RemoteSlot *remote_slot, Oid remote_dbid)`
`725`	`725`	`remote_slot->name,`
`726`	`726`	`LSN_FORMAT_ARGS(latestFlushPtr)));`
`727`	`727`
	`728`	`+ReplicationSlotRelease();`
	`729`	`+`
`728`	`730`	`returnslot_updated;`
`729`	`731`	`}`
`730`	`732`
`@@ -824,6 +826,8 @@ synchronize_one_slot(RemoteSlot *remote_slot, Oid remote_dbid)`
`824`	`826`	`remote_slot->name,`
`825`	`827`	`LSN_FORMAT_ARGS(latestFlushPtr)));`
`826`	`828`
	`829`	`+ReplicationSlotRelease();`
	`830`	`+`
`827`	`831`	`return false;`
`828`	`832`	`}`
`829`	`833`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3df4df5

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/slotsync.c‎`

0 commit comments