NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit3d858af

committed

psql: initialize comment-begin setting to a useful value by default.

Readline's meta-# command is supposed to insert a comment markerat the start of the current line. However, the default marker is"#" which is entirely unhelpful for SQL. Set it to "-- " instead.(This setting can still be overridden in one's ~/.inputrc file,so this change won't affect people who have already taken stepsto make the command useful.)Discussion:https://postgr.es/m/CAJcOf-cAdMVr7azeYR7nWKsNp7qhORzc84rV6d7m7knG5Hrtsw@mail.gmail.com

1 parentc2f6549 commit3d858afCopy full SHA for 3d858af

File tree

1 file changed

-1

lines changed

src/bin/psql
- input.c

1 file changed

-1

lines changed

`‎src/bin/psql/input.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -353,8 +353,13 @@ initializeInput(int flags)`
`353`	`353`
`354`	`354`	`useReadline= true;`
`355`	`355`
`356`		`-/these two things must be done in this order: /`
	`356`	`+/set appropriate values for Readline's global variables /`
`357`	`357`	`initialize_readline();`
	`358`	`+`
	`359`	`+/* set comment-begin to a useful value for SQL */`
	`360`	`+(void)rl_variable_bind("comment-begin","-- ");`
	`361`	`+`
	`362`	`+/* this reads ~/.inputrc, so do it after rl_variable_bind */`
`358`	`363`	`rl_initialize();`
`359`	`364`
`360`	`365`	`useHistory= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3d858af

File tree

1 file changed

1 file changed

`‎src/bin/psql/input.c`

0 commit comments