Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit384f933

Browse files
committed
Fix regression test make dependencies
The dependencies on the spi and dummy_seclabel contrib modules wereincomplete, because they did not pick up automatically generateddependencies on header files. This will manifest itself especially whenswitching major versions, where the contrib modules would not berecompiled to contain the new version number, leading to regression testfailures.To fix this, use the submake approach already in use elsewhere, so thatthe contrib modules are built using their full rules.
1 parent605b4c5 commit384f933

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

‎src/test/regress/GNUmakefile

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,19 @@ autoinc$(DLSUFFIX): $(top_builddir)/contrib/spi/autoinc$(DLSUFFIX)
111111
dummy_seclabel$(DLSUFFIX):$(top_builddir)/contrib/dummy_seclabel/dummy_seclabel$(DLSUFFIX)
112112
cp$<$@
113113

114-
$(top_builddir)/contrib/spi/refint$(DLSUFFIX):$(top_srcdir)/contrib/spi/refint.c
115-
$(MAKE) -C$(top_builddir)/contrib/spi refint$(DLSUFFIX)
114+
$(top_builddir)/contrib/spi/refint$(DLSUFFIX): | submake-contrib-spi ;
116115

117-
$(top_builddir)/contrib/spi/autoinc$(DLSUFFIX):$(top_srcdir)/contrib/spi/autoinc.c
118-
$(MAKE) -C$(top_builddir)/contrib/spi autoinc$(DLSUFFIX)
116+
$(top_builddir)/contrib/spi/autoinc$(DLSUFFIX): | submake-contrib-spi ;
119117

120-
$(top_builddir)/contrib/dummy_seclabel/dummy_seclabel$(DLSUFFIX):$(top_builddir)/contrib/dummy_seclabel/dummy_seclabel.c
121-
$(MAKE) -C$(top_builddir)/contrib/dummy_seclabel dummy_seclabel$(DLSUFFIX)
118+
$(top_builddir)/contrib/dummy_seclabel/dummy_seclabel$(DLSUFFIX): | submake-contrib-dummy_seclabel ;
119+
120+
submake-contrib-spi:
121+
$(MAKE) -C$(top_builddir)/contrib/spi
122+
123+
submake-contrib-dummy_seclabel:
124+
$(MAKE) -C$(top_builddir)/contrib/dummy_seclabel
125+
126+
.PHONY: submake-contrib-spi submake-contrib-dummy_seclabel
122127

123128
# Tablespace setup
124129

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp