NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit369342c

committed

Cap wal_buffers to avoid a server crash when it's set very large.

It must be possible to multiply wal_buffers by XLOG_BLCKSZ withoutoverflowing int, or calculations in StartupXLOG will go badly wrongand crash the server. Avoid that by imposing a maximum value onwal_buffers. This will be just under 2GB, assuming the usual valuefor XLOG_BLCKSZ.Josh Berkus, per an analysis by Andrew Gierth.

1 parent158e3bc commit369342cCopy full SHA for 369342c

File tree

1 file changed

-1

lines changed

src/backend/utils/misc
- guc.c

1 file changed

-1

lines changed

`‎src/backend/utils/misc/guc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2215,7 +2215,7 @@ static struct config_int ConfigureNamesInt[] =`
`2215`	`2215`	`GUC_UNIT_XBLOCKS`
`2216`	`2216`	`},`
`2217`	`2217`	`&XLOGbuffers,`
`2218`		`--1,-1,INT_MAX,`
	`2218`	`+-1,-1,(INT_MAX /XLOG_BLCKSZ),`
`2219`	`2219`	`check_wal_buffers,NULL,NULL`
`2220`	`2220`	`},`
`2221`	`2221`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit369342c

File tree

1 file changed

1 file changed

`‎src/backend/utils/misc/guc.c`

0 commit comments