NotificationsYou must be signed in to change notification settings
Fork5.3k
Star19.2k

Commit33bb3dc

committed

pg_dump tests: don't put dumps in stdout

This bloats the regression log files for no reason.Backpatch to 18; no further only because it fails to apply cleanly.(It's just whitespace change that conflicts, but I don't think thiswarrants more effort than this.)Discussion:https://postgr.es/m/202511251218.zfs4nu2qnh2m@alvherre.pgsql

1 parent417ac9c commit33bb3dcCopy full SHA for 33bb3dc

File tree

1 file changed

-2

lines changed

src/bin/pg_dump/t
- 002_pg_dump.pl

1 file changed

-2

lines changed

`‎src/bin/pg_dump/t/002_pg_dump.pl‎`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5019,7 +5019,12 @@`
`5019`	`5019`	`# Test dumping pg_catalog (for research -- cannot be reloaded)`
`5020`	`5020`
`5021`	`5021`	`$node->command_ok(`
`5022`		`-[ 'pg_dump', '--port' =>$port, '--schema' => 'pg_catalog' ],`
	`5022`	`+[`
	`5023`	`+'pg_dump',`
	`5024`	`+'--port' =>$port,`
	`5025`	`+'--schema' => 'pg_catalog',`
	`5026`	`+'--file' => "$tempdir/pgdump_pgcatalog.dmp"`
	`5027`	`+],`
`5023`	`5028`	`'pg_dump: option -n pg_catalog');`
`5024`	`5029`
`5025`	`5030`	`#########################################`
`@@ -5029,7 +5034,8 @@`
`5029`	`5034`	`[`
`5030`	`5035`	`'pg_dumpall',`
`5031`	`5036`	`'--port' =>$port,`
`5032`		`-'--exclude-database' => '"myhost.mydb"'`
	`5037`	`+'--exclude-database' => '"myhost.mydb"',`
	`5038`	`+'--file' => "$tempdir/pgdumpall.dmp"`
`5033`	`5039`	`],`
`5034`	`5040`	`'pg_dumpall: option --exclude-database handles database names with embedded dots'`
`5035`	`5041`	`);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit33bb3dc

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/t/002_pg_dump.pl‎`

0 commit comments