Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit332c694

Browse files
committed
Fix nasty little order-of-operations bug in _SPI_cursor_operation.
Per report from Mendola Gaetano.
1 parent4ae02fd commit332c694

File tree

1 file changed

+17
-6
lines changed
  • src/backend/executor

1 file changed

+17
-6
lines changed

‎src/backend/executor/spi.c

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.101 2003/08/04 02:39:59 momjian Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/executor/spi.c,v 1.102 2003/08/08 19:18:21 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1263,6 +1263,8 @@ static void
12631263
_SPI_cursor_operation(Portalportal,boolforward,intcount,
12641264
DestReceiver*dest)
12651265
{
1266+
longnfetched;
1267+
12661268
/* Check that the portal is valid */
12671269
if (!PortalIsValid(portal))
12681270
elog(ERROR,"invalid portal in SPI cursor operation");
@@ -1277,11 +1279,20 @@ _SPI_cursor_operation(Portal portal, bool forward, int count,
12771279
_SPI_current->tuptable=NULL;
12781280

12791281
/* Run the cursor */
1280-
_SPI_current->processed=
1281-
PortalRunFetch(portal,
1282-
forward ?FETCH_FORWARD :FETCH_BACKWARD,
1283-
(long)count,
1284-
dest);
1282+
nfetched=PortalRunFetch(portal,
1283+
forward ?FETCH_FORWARD :FETCH_BACKWARD,
1284+
(long)count,
1285+
dest);
1286+
1287+
/*
1288+
* Think not to combine this store with the preceding function call.
1289+
* If the portal contains calls to functions that use SPI, then
1290+
* SPI_stack is likely to move around while the portal runs. When
1291+
* control returns, _SPI_current will point to the correct stack entry...
1292+
* but the pointer may be different than it was beforehand. So we must
1293+
* be sure to re-fetch the pointer after the function call completes.
1294+
*/
1295+
_SPI_current->processed=nfetched;
12851296

12861297
if (dest->mydest==SPI&&_SPI_checktuples())
12871298
elog(ERROR,"consistency check on SPI tuple count failed");

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp