NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit32951f9

committed

vacuumdb: Don't assign negative values to a boolean.

Sincea179232 (vacuumdb: enable parallel mode) -1 has been assignedto a boolean. That can, justifiedly, trigger compiler warnings. There'salso no need for ternary logic, result was only ever set to 0 or -1. Sodon't.Discussion: 20150812084351.GD8470@awork2.anarazel.deBackpatch: 9.5

1 parentd19c1b0 commit32951f9Copy full SHA for 32951f9

File tree

1 file changed

-4

lines changed

src/bin/scripts
- vacuumdb.c

1 file changed

-4

lines changed

`‎src/bin/scripts/vacuumdb.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`339`	`339`	`ParallelSlot*slots=NULL;`
`340`	`340`	`SimpleStringListdbtables= {NULL,NULL};`
`341`	`341`	`inti;`
`342`		`-boolresult=0;`
	`342`	`+boolfailed=false;`
`343`	`343`	`boolparallel=concurrentCons>1;`
`344`	`344`	`constchar*stage_commands[]= {`
`345`	`345`	`"SET default_statistics_target=1; SET vacuum_cost_delay=0;",`
`@@ -457,7 +457,7 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`457`	`457`
`458`	`458`	`if (CancelRequested)`
`459`	`459`	`{`
`460`		`-result=-1;`
	`460`	`+failed=true;`
`461`	`461`	`gotofinish;`
`462`	`462`	`}`
`463`	`463`
`@@ -476,7 +476,7 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`476`	`476`	`free_slot=GetIdleSlot(slots,concurrentCons,dbname,progname);`
`477`	`477`	`if (!free_slot)`
`478`	`478`	`{`
`479`		`-result=-1;`
	`479`	`+failed=true;`
`480`	`480`	`gotofinish;`
`481`	`481`	`}`
`482`	`482`
`@@ -518,7 +518,7 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`518`	`518`
`519`	`519`	`termPQExpBuffer(&sql);`
`520`	`520`
`521`		`-if (result==-1)`
	`521`	`+if (failed)`
`522`	`522`	`exit(1);`
`523`	`523`	`}`
`524`	`524`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit32951f9

File tree

1 file changed

1 file changed

`‎src/bin/scripts/vacuumdb.c`

0 commit comments