Commit3208b4d

committed

There is a bug in aclitemout which causes a notice to be sent to the client

while the backend is trying to pfree a string not allocated with palloc.Submitted by: Massimo Dal Zotto <dz@cs.unitn.it>

1 parentba30435 commit3208b4dCopy full SHA for 3208b4d

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.1.1.1 1996/07/09 06:22:02 scrappy Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.1.1.1.2.1 1996/10/11 03:15:38 scrappy Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -258,7 +258,11 @@ aclitemout(AclItem *aip)`
`258`	`258`	`(void)strcat(p,"group ");`
`259`	`259`	`tmpname=get_groname(aip->ai_id);`
`260`	`260`	`(void)strncat(p,tmpname,NAMEDATALEN);`
	`261`	`+#ifdefACL_PATCH`
	`262`	`+/* tmpname is a pointer into tuple data, don't pfree it */`
	`263`	`+#else`
`261`	`264`	`pfree(tmpname);`
	`265`	`+#endif`
`262`	`266`	`break;`
`263`	`267`	`caseACL_IDTYPE_WORLD:`
`264`	`268`	`break;`

Comments

(0)