Commit2f98f96

committed

Improve comments for TidRangeEval

Here we provide a bit more detail on why TidRangeEval() does return falsewhen trss_mintid is greater than trss_maxtid.Reported-by: Junwang Zhao <zhjwpku@gmail.com>Author: David Rowley <dgrowleyml@gmail.com>Reviewed-by: Junwang Zhao <zhjwpku@gmail.com>Discussion:https://postgr.es/m/CAEG8a3KUbUUqQgfK5X8Sj-%2BppPtGNTU%2BZiep0Rxr7SLjoR%2BB6w%40mail.gmail.com

1 parent0fe5041 commit2f98f96Copy full SHA for 2f98f96

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,9 +128,11 @@ TidExprListCreate(TidRangeScanState *tidrangestate)`
`128`	`128`	`*TidRangeEval`
`129`	`129`	`*`
`130`	`130`	`*Compute and set node's block and offset range to scan by evaluating`
`131`		`- *thetrss_tidexprs. Returns false if we detect the range cannot`
	`131`	`+ *node->trss_tidexprs. Returns false if we detect the range cannot`
`132`	`132`	`*contain any tuples. Returns true if it's possible for the range to`
`133`		`- *contain tuples.`
	`133`	`+ *contain tuples. We don't bother validating that trss_mintid is less`
	`134`	`+ *than or equal to trss_maxtid, as the scan_set_tidrange() table AM`
	`135`	`+ *function will handle that.`
`134`	`136`	`* ----------------------------------------------------------------`
`135`	`137`	`*/`
`136`	`138`	`staticbool`

Comments

(0)