NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commit2e62fa6

committed

Avoid core dump after getpwuid_r failure.

Looking up a nonexistent user ID would lead to a null pointerdereference. That's unlikely to happen here, but perhapsnot impossible.Thinko in commit4d5111b, noticed by Coverity.

1 parentd8df7ac commit2e62fa6Copy full SHA for 2e62fa6

File tree

1 file changed

-2

lines changed

src/interfaces/libpq
- fe-auth.c

1 file changed

-2

lines changed

`‎src/interfaces/libpq/fe-auth.c‎`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1205,7 +1205,7 @@ pg_fe_getusername(uid_t user_id, PQExpBuffer errorMessage)`
`1205`	`1205`	`DWORDnamesize=sizeof(username);`
`1206`	`1206`	`#else`
`1207`	`1207`	`structpasswdpwbuf;`
`1208`		`-structpasswd*pw;`
	`1208`	`+structpasswd*pw=NULL;`
`1209`	`1209`	`charbuf[1024];`
`1210`	`1210`	`intrc;`
`1211`	`1211`	`#endif`
`@@ -1230,7 +1230,8 @@ pg_fe_getusername(uid_t user_id, PQExpBuffer errorMessage)`
`1230`	`1230`	`if (errorMessage)`
`1231`	`1231`	`libpq_append_error(errorMessage,"local user with ID %ld does not exist", (long)user_id);`
`1232`	`1232`	`}`
`1233`		`-name=pw->pw_name;`
	`1233`	`+else`
	`1234`	`+name=pw->pw_name;`
`1234`	`1235`	`#endif`
`1235`	`1236`
`1236`	`1237`	`if (name)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2e62fa6

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-auth.c‎`

0 commit comments