- Notifications
You must be signed in to change notification settings - Fork5k
Commit2e37286
committed
Don't let libpq PGEVT_CONNRESET callbacks break a PGconn.
As currently implemented, failure of a PGEVT_CONNRESET callbackforces the PGconn into the CONNECTION_BAD state (without closingthe socket, which is inconsistent with other failure paths), andprevents later callbacks from being called. This seems highlyquestionable, and indeed is questioned by comments in the source.Instead, let's just ignore the result value of PGEVT_CONNRESETcalls. Like the preceding commit, this converts event callbacksinto "pure observers" that cannot affect libpq's processing logic.Discussion:https://postgr.es/m/3185105.1644960083@sss.pgh.pa.us1 parentce1e7a2 commit2e37286
2 files changed
+11
-28
lines changedLines changed: 5 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7183 | 7183 |
| |
7184 | 7184 |
| |
7185 | 7185 |
| |
7186 |
| - | |
7187 |
| - | |
7188 |
| - | |
7189 |
| - | |
7190 |
| - | |
7191 |
| - | |
| 7186 | + | |
| 7187 | + | |
| 7188 | + | |
| 7189 | + | |
| 7190 | + | |
7192 | 7191 |
| |
7193 | 7192 |
| |
7194 | 7193 |
| |
|
Lines changed: 6 additions & 22 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4276 | 4276 |
| |
4277 | 4277 |
| |
4278 | 4278 |
| |
4279 |
| - | |
4280 |
| - | |
| 4279 | + | |
4281 | 4280 |
| |
4282 | 4281 |
| |
4283 | 4282 |
| |
| |||
4286 | 4285 |
| |
4287 | 4286 |
| |
4288 | 4287 |
| |
4289 |
| - | |
4290 |
| - | |
4291 |
| - | |
4292 |
| - | |
4293 |
| - | |
4294 |
| - | |
4295 |
| - | |
4296 |
| - | |
4297 |
| - | |
| 4288 | + | |
| 4289 | + | |
4298 | 4290 |
| |
4299 | 4291 |
| |
4300 | 4292 |
| |
| |||
4336 | 4328 |
| |
4337 | 4329 |
| |
4338 | 4330 |
| |
4339 |
| - | |
4340 |
| - | |
| 4331 | + | |
4341 | 4332 |
| |
4342 | 4333 |
| |
4343 | 4334 |
| |
| |||
4346 | 4337 |
| |
4347 | 4338 |
| |
4348 | 4339 |
| |
4349 |
| - | |
4350 |
| - | |
4351 |
| - | |
4352 |
| - | |
4353 |
| - | |
4354 |
| - | |
4355 |
| - | |
4356 |
| - | |
4357 |
| - | |
| 4340 | + | |
| 4341 | + | |
4358 | 4342 |
| |
4359 | 4343 |
| |
4360 | 4344 |
| |
|
0 commit comments
Comments
(0)