NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit2c0ed86

Richard Guo

committed

Add explicit initialization for all PlannerGlobal fields

When creating a new PlannerGlobal node in standard_planner(), mostfields are explicitly initialized, but a few are not. This doesn'tcause any functional issues, as makeNode() zeroes all fields bydefault. However, the inconsistency is undesirable from a clarity andmaintenance perspective.This patch explicitly initializes the remaining fields to improveconsistency and readability.Author: Richard Guo <guofenglinux@gmail.com>Reviewed-by: David Rowley <dgrowleyml@gmail.com>Discussion:https://postgr.es/m/CAMbWs4-TgQHNOiouqGcuHoBqbJjWyx4UxGKxUY3FrF4trGbcPA@mail.gmail.com

1 parent6e289f2 commit2c0ed86Copy full SHA for 2c0ed86

File tree

1 file changed

-0

lines changed

src/backend/optimizer/plan
- planner.c

1 file changed

-0

lines changed

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -326,10 +326,14 @@ standard_planner(Query parse, const char query_string, int cursorOptions,`
`326`	`326`	`glob->subroots=NIL;`
`327`	`327`	`glob->rewindPlanIDs=NULL;`
`328`	`328`	`glob->finalrtable=NIL;`
	`329`	`+glob->allRelids=NULL;`
	`330`	`+glob->prunableRelids=NULL;`
`329`	`331`	`glob->finalrteperminfos=NIL;`
`330`	`332`	`glob->finalrowmarks=NIL;`
`331`	`333`	`glob->resultRelations=NIL;`
	`334`	`+glob->firstResultRels=NIL;`
`332`	`335`	`glob->appendRelations=NIL;`
	`336`	`+glob->partPruneInfos=NIL;`
`333`	`337`	`glob->relationOids=NIL;`
`334`	`338`	`glob->invalItems=NIL;`
`335`	`339`	`glob->paramExecTypes=NIL;`
`@@ -338,6 +342,7 @@ standard_planner(Query parse, const char query_string, int cursorOptions,`
`338`	`342`	`glob->lastPlanNodeId=0;`
`339`	`343`	`glob->transientPlan= false;`
`340`	`344`	`glob->dependsOnRole= false;`
	`345`	`+glob->partition_directory=NULL;`
`341`	`346`
`342`	`347`	`/*`
`343`	`348`	`* Assess whether it's feasible to use parallel mode for this query. We`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2c0ed86

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planner.c`

0 commit comments