- Notifications
You must be signed in to change notification settings - Fork5.2k
Commit2a2e1b4
committed
bufmgr: Fix signedness of mask variable in BufferSync()
BM_PERMANENT is defined as 1U<<31, which is a negative number when interpretedas a signed integer. Unfortunately the mask variable in BufferSync() wassigned. This has been wrong for a long time, but failed to fail, due tointeger conversion rules.However, in an upcoming patch the width of the state variable will beincreased, with the wrong signedness leading to never flushing permanentbuffers - luckily caught in a test.It seems better to fix this separately, instead of doing so as part of alarge, otherwise mechanical, patch.Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com>Discussion:https://postgr.es/m/fvfmkr5kk4nyex56ejgxj3uzi63isfxovp2biecb4bspbjrze7@az2pljabhnff1 parent3c2b97b commit2a2e1b4
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3321 | 3321 | | |
3322 | 3322 | | |
3323 | 3323 | | |
3324 | | - | |
| 3324 | + | |
3325 | 3325 | | |
3326 | 3326 | | |
3327 | 3327 | | |
| |||
0 commit comments
Comments
(0)