Commit29fd3d9

committed

Don't permit transition tables with TRUNCATE triggers.

Prior to this prohibition, such a trigger caused a crash.Thomas Munro, per a report from Neha Sharma. I added aregression test.Discussion:http://postgr.es/m/CAEepm=0VR5W-N38eTkO_FqJbGqQ_ykbBRmzmvHyxDhy1p=0Csw@mail.gmail.com

1 parent304007d commit29fd3d9Copy full SHA for 29fd3d9

File tree

+21

-0

lines changed

+21

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -366,6 +366,11 @@ CreateTrigger(CreateTrigStmt stmt, const char queryString,`
`366`	`366`	`(errcode(ERRCODE_INVALID_OBJECT_DEFINITION),`
`367`	`367`	`errmsg("transition table name can only be specified for an AFTER trigger")));`
`368`	`368`
	`369`	`+if (TRIGGER_FOR_TRUNCATE(tgtype))`
	`370`	`+ereport(ERROR,`
	`371`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`372`	`+errmsg("TRUNCATE triggers with transition tables are not supported")));`
	`373`	`+`
`369`	`374`	`if (tt->isNew)`
`370`	`375`	`{`
`371`	`376`	`if (!(TRIGGER_FOR_INSERT(tgtype)\|\|`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5943,6 +5943,14 @@ BEGIN`
`5943`	`5943`	`RETURN NULL;`
`5944`	`5944`	`END;`
`5945`	`5945`	`$$;`
	`5946`	`+-- should fail, TRUNCATE is not compatible with transition tables`
	`5947`	`+CREATE TRIGGER alter_table_under_transition_tables_upd_trigger`
	`5948`	`+ AFTER TRUNCATE OR UPDATE ON alter_table_under_transition_tables`
	`5949`	`+ REFERENCING OLD TABLE AS d NEW TABLE AS i`
	`5950`	`+ FOR EACH STATEMENT EXECUTE PROCEDURE`
	`5951`	`+ alter_table_under_transition_tables_upd_func();`
	`5952`	`+ERROR: TRUNCATE triggers with transition tables are not supported`
	`5953`	`+-- should work`
`5946`	`5954`	`CREATE TRIGGER alter_table_under_transition_tables_upd_trigger`
`5947`	`5955`	`AFTER UPDATE ON alter_table_under_transition_tables`
`5948`	`5956`	`REFERENCING OLD TABLE AS d NEW TABLE AS i`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4736,6 +4736,14 @@ BEGIN`
`4736`	`4736`	`END;`
`4737`	`4737`	`$$;`
`4738`	`4738`
	`4739`	`+-- should fail, TRUNCATE is not compatible with transition tables`
	`4740`	`+CREATETRIGGERalter_table_under_transition_tables_upd_trigger`
	`4741`	`+ AFTER TRUNCATEORUPDATEON alter_table_under_transition_tables`
	`4742`	`+ REFERENCING OLD TABLEAS d NEW TABLEAS i`
	`4743`	`+ FOR EACH STATEMENT EXECUTE PROCEDURE`
	`4744`	`+ alter_table_under_transition_tables_upd_func();`
	`4745`	`+`
	`4746`	`+-- should work`
`4739`	`4747`	`CREATETRIGGERalter_table_under_transition_tables_upd_trigger`
`4740`	`4748`	`AFTERUPDATEON alter_table_under_transition_tables`
`4741`	`4749`	`REFERENCING OLD TABLEAS d NEW TABLEAS i`

Comments

(0)