- Notifications
You must be signed in to change notification settings - Fork5.2k
Commit2550508
Amit Kapila
Improve log messages and docs for slot synchronization.
Improve the clarity of LOG messages when a failover logical slotsynchronization fails, making the reasons more explicit for easierdebugging.Update the documentation to outline scenarios where slot synchronizationcan fail, especially during the initial sync, and emphasize thatpg_sync_replication_slot() is primarily intended for testing anddebugging purposes.We also discussed improving the functionality ofpg_sync_replication_slot() so that it can be used reliably, but we wouldtake up that work for next version after some more discussion and review.Reported-by: Suraj Kharage <suraj.kharage@enterprisedb.com>Author: shveta malik <shveta.malik@gmail.com>Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com>Reviewed-by: Peter Smith <smithpb2250@gmail.com>Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>Backpatch-through: 17, where it was introducedDiscussion:https://postgr.es/m/CAF1DzPWTcg+m+x+oVVB=y4q9=PYYsL_mujVp7uJr-_oUtWNGbA@mail.gmail.com1 parent45c357e commit2550508
File tree
3 files changed
+57
-9
lines changed- doc/src/sgml
- src/backend/replication/logical
3 files changed
+57
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29177 | 29177 | | |
29178 | 29178 | | |
29179 | 29179 | | |
29180 | | - | |
| 29180 | + | |
29181 | 29181 | | |
29182 | 29182 | | |
29183 | 29183 | | |
| |||
29448 | 29448 | | |
29449 | 29449 | | |
29450 | 29450 | | |
29451 | | - | |
| 29451 | + | |
| 29452 | + | |
| 29453 | + | |
29452 | 29454 | | |
29453 | 29455 | | |
29454 | 29456 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
401 | 447 | | |
402 | 448 | | |
403 | 449 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | | - | |
| 217 | + | |
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
580 | | - | |
| 580 | + | |
581 | 581 | | |
582 | 582 | | |
583 | 583 | | |
| |||
0 commit comments
Comments
(0)