Commit24eca79

committed

Assign InvalidXLogRecPtr instead of MemSet(0)

For consistency.Author: Andres Freund

1 parenteaa1f72 commit24eca79Copy full SHA for 24eca79

File tree

-5

lines changed

-5

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -6393,8 +6393,8 @@ CheckRecoveryConsistency(void)`
`6393`	`6393`	`if (XLByteLT(ControlFile->minRecoveryPoint,EndRecPtr))`
`6394`	`6394`	`ControlFile->minRecoveryPoint=EndRecPtr;`
`6395`	`6395`
`6396`		`-MemSet(&ControlFile->backupStartPoint,0,sizeof(XLogRecPtr));`
`6397`		`-MemSet(&ControlFile->backupEndPoint,0,sizeof(XLogRecPtr));`
	`6396`	`+ControlFile->backupStartPoint=InvalidXLogRecPtr;`
	`6397`	`+ControlFile->backupEndPoint=InvalidXLogRecPtr;`
`6398`	`6398`	`ControlFile->backupEndRequired= false;`
`6399`	`6399`	`UpdateControlFile();`
`6400`	`6400`
`@@ -7330,7 +7330,7 @@ CreateCheckPoint(int flags)`
`7330`	`7330`	`ControlFile->checkPointCopy=checkPoint;`
`7331`	`7331`	`ControlFile->time= (pg_time_t)time(NULL);`
`7332`	`7332`	`/* crash recovery should always recover to the end of WAL */`
`7333`		`-MemSet(&ControlFile->minRecoveryPoint,0,sizeof(XLogRecPtr));`
	`7333`	`+ControlFile->minRecoveryPoint=InvalidXLogRecPtr;`
`7334`	`7334`	`ControlFile->minRecoveryPointTLI=0;`
`7335`	`7335`	`UpdateControlFile();`
`7336`	`7336`	`LWLockRelease(ControlFileLock);`
`@@ -8161,7 +8161,7 @@ xlog_redo(XLogRecPtr lsn, XLogRecord *record)`
`8161`	`8161`	`ControlFile->minRecoveryPoint=lsn;`
`8162`	`8162`	`ControlFile->minRecoveryPointTLI=ThisTimeLineID;`
`8163`	`8163`	`}`
`8164`		`-MemSet(&ControlFile->backupStartPoint,0,sizeof(XLogRecPtr));`
	`8164`	`+ControlFile->backupStartPoint=InvalidXLogRecPtr;`
`8165`	`8165`	`ControlFile->backupEndRequired= false;`
`8166`	`8166`	`UpdateControlFile();`
`8167`	`8167`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1115,7 +1115,7 @@ InitWalSenderSlot(void)`
`1115`	`1115`	`* Found a free slot. Reserve it for us.`
`1116`	`1116`	`*/`
`1117`	`1117`	`walsnd->pid=MyProcPid;`
`1118`		`-MemSet(&walsnd->sentPtr,0,sizeof(XLogRecPtr));`
	`1118`	`+walsnd->sentPtr=InvalidXLogRecPtr;`
`1119`	`1119`	`walsnd->state=WALSNDSTATE_STARTUP;`
`1120`	`1120`	`SpinLockRelease(&walsnd->mutex);`
`1121`	`1121`	`/* don't need the lock anymore */`

Comments

(0)