- Notifications
You must be signed in to change notification settings - Fork4.9k
Commit2406c4e
committed
Reword messages about impending (M)XID exhaustion.
First, we shouldn't recommend switching to single-user mode, becausethat's terrible advice. Especially on newer versions where VACUUMwill enter emergency mode when nearing (M)XID exhaustion, it'sperfectly fine to just VACUUM in multi-user mode. Doing it that wayis less disruptive and avoids disabling the safeguards that preventactual wraparound, so recommend that instead.Second, be more precise about what is going to happen (when we'renearing the limits) or what is happening (when we actually hit them).The database doesn't shut down, nor does it refuse all commands. Itrefuses commands that assign whichever of XIDs and MXIDs are nearlyexhausted.No back-patch. The existing hint that advises going to single-usermode is sufficiently awful advice that removing it or changing itmight be justifiable even though we normally avoid changinguser-facing messages in back-branches, but I (rhaas) felt that itwas better to be more conservative and limit this fix to masteronly. Aside from the usual risk of breaking translations, peoplemight be used to the existing message, or even have monitoringscripts that look for it.Alexander Alekseev, John Naylor, Robert Haas, reviewed at varioustimes by Peter Geoghegan, Hannu Krosing, and Andres Freund.Discussion:http://postgr.es/m/CA+TgmoZBg95FiR9wVQPAXpGPRkacSt2okVge+PKPPFppN7sfnQ@mail.gmail.com1 parenta1a5da8 commit2406c4e
File tree
3 files changed
+16
-15
lines changed- doc/src/sgml
- src/backend/access/transam
3 files changed
+16
-15
lines changedLines changed: 6 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
656 | 656 |
| |
657 | 657 |
| |
658 | 658 |
| |
659 |
| - | |
| 659 | + | |
660 | 660 |
| |
661 | 661 |
| |
662 | 662 |
| |
| |||
667 | 667 |
| |
668 | 668 |
| |
669 | 669 |
| |
670 |
| - | |
671 |
| - | |
| 670 | + | |
| 671 | + | |
672 | 672 |
| |
673 | 673 |
| |
674 | 674 |
| |
675 | 675 |
| |
676 | 676 |
| |
677 | 677 |
| |
678 |
| - | |
679 |
| - | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
680 | 681 |
| |
681 | 682 |
| |
682 | 683 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2335 | 2335 |
| |
2336 | 2336 |
| |
2337 | 2337 |
| |
2338 |
| - | |
| 2338 | + | |
2339 | 2339 |
| |
2340 | 2340 |
| |
2341 | 2341 |
| |
| |||
2344 | 2344 |
| |
2345 | 2345 |
| |
2346 | 2346 |
| |
2347 |
| - | |
| 2347 | + | |
2348 | 2348 |
| |
2349 | 2349 |
| |
2350 | 2350 |
| |
|
Lines changed: 8 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
126 | 126 |
| |
127 | 127 |
| |
128 | 128 |
| |
129 |
| - | |
| 129 | + | |
130 | 130 |
| |
131 |
| - | |
| 131 | + | |
132 | 132 |
| |
133 | 133 |
| |
134 | 134 |
| |
135 | 135 |
| |
136 |
| - | |
| 136 | + | |
137 | 137 |
| |
138 |
| - | |
| 138 | + | |
139 | 139 |
| |
140 | 140 |
| |
141 | 141 |
| |
| |||
148 | 148 |
| |
149 | 149 |
| |
150 | 150 |
| |
151 |
| - | |
| 151 | + | |
152 | 152 |
| |
153 | 153 |
| |
154 | 154 |
| |
155 | 155 |
| |
156 | 156 |
| |
157 | 157 |
| |
158 |
| - | |
| 158 | + | |
159 | 159 |
| |
160 | 160 |
| |
161 | 161 |
| |
| |||
463 | 463 |
| |
464 | 464 |
| |
465 | 465 |
| |
466 |
| - | |
| 466 | + | |
467 | 467 |
| |
468 | 468 |
| |
469 | 469 |
| |
470 | 470 |
| |
471 | 471 |
| |
472 | 472 |
| |
473 |
| - | |
| 473 | + | |
474 | 474 |
| |
475 | 475 |
| |
476 | 476 |
| |
|
0 commit comments
Comments
(0)