Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit21a9b2b

Browse files
committed
Rename injection point for invalidation messages at end of transaction
This injection point was named "AtEOXact_Inval-with-transInvalInfo", notrespecting the implied naming convention that injection points shoulduse lower-case characters, with terms separated by dashes. All theother points defined in the tree follow this style, so let's be moreconsistent.Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>Discussion:https://postgr.es/m/OSCPR01MB14966E14C1378DEE51FB7B7C5F5B32@OSCPR01MB14966.jpnprd01.prod.outlook.comBackpatch-through: 17
1 parent12bf434 commit21a9b2b

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎src/backend/utils/cache/inval.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ AtEOXact_Inval(bool isCommit)
10321032
/* Must be at top of stack */
10331033
Assert(transInvalInfo->my_level==1&&transInvalInfo->parent==NULL);
10341034

1035-
INJECTION_POINT("AtEOXact_Inval-with-transInvalInfo");
1035+
INJECTION_POINT("transaction-end-process-inval");
10361036

10371037
if (isCommit)
10381038
{

‎src/test/modules/injection_points/expected/syscache-update-pruned.out

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ step waitprunable4: CALL vactest.wait_prunable();
1010
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
1111
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
1212
step wakeinval4:
13-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
14-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
13+
SELECT FROM injection_points_detach('transaction-end-process-inval');
14+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
1515
<waiting ...>
1616
step at2: <... completed>
1717
step wakeinval4: <... completed>
@@ -33,8 +33,8 @@ step waitprunable4: CALL vactest.wait_prunable();
3333
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
3434
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
3535
step wakeinval4:
36-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
37-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
36+
SELECT FROM injection_points_detach('transaction-end-process-inval');
37+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
3838
<waiting ...>
3939
step at2: <... completed>
4040
step wakeinval4: <... completed>
@@ -64,8 +64,8 @@ step waitprunable4: CALL vactest.wait_prunable();
6464
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
6565
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
6666
step wakeinval4:
67-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
68-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
67+
SELECT FROM injection_points_detach('transaction-end-process-inval');
68+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
6969
<waiting ...>
7070
step at2: <... completed>
7171
step wakeinval4: <... completed>

‎src/test/modules/injection_points/expected/syscache-update-pruned_1.out

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ step waitprunable4: CALL vactest.wait_prunable();
1010
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
1111
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
1212
step wakeinval4:
13-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
14-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
13+
SELECT FROM injection_points_detach('transaction-end-process-inval');
14+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
1515
<waiting ...>
1616
step at2: <... completed>
1717
step wakeinval4: <... completed>
@@ -32,8 +32,8 @@ step waitprunable4: CALL vactest.wait_prunable();
3232
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
3333
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
3434
step wakeinval4:
35-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
36-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
35+
SELECT FROM injection_points_detach('transaction-end-process-inval');
36+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
3737
<waiting ...>
3838
step at2: <... completed>
3939
step wakeinval4: <... completed>
@@ -62,8 +62,8 @@ step waitprunable4: CALL vactest.wait_prunable();
6262
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
6363
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
6464
step wakeinval4:
65-
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
66-
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
65+
SELECT FROM injection_points_detach('transaction-end-process-inval');
66+
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
6767
<waiting ...>
6868
step at2: <... completed>
6969
step wakeinval4: <... completed>

‎src/test/modules/injection_points/specs/syscache-update-pruned.spec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ session s2
117117
setup{
118118
SELECTFROMinjection_points_set_local();
119119
SELECTFROM
120-
injection_points_attach('AtEOXact_Inval-with-transInvalInfo','wait');
120+
injection_points_attach('transaction-end-process-inval','wait');
121121
}
122122
stepat2{
123123
CREATETRIGGERto_set_relhastriggersBEFOREUPDATEONvactest.orig50
@@ -145,8 +145,8 @@ step wakegrant4{
145145
}
146146
stepat4{ALTERTABLEvactest.child50INHERITvactest.orig50; }
147147
stepwakeinval4{
148-
SELECTFROMinjection_points_detach('AtEOXact_Inval-with-transInvalInfo');
149-
SELECTFROMinjection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
148+
SELECTFROMinjection_points_detach('transaction-end-process-inval');
149+
SELECTFROMinjection_points_wakeup('transaction-end-process-inval');
150150
}
151151
# Witness effects of steps at2 and/or at4.
152152
stepinspect4{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp