NotificationsYou must be signed in to change notification settings
Fork5k
Star18.1k

Commit1dbe6f7

committed

Refactor non-supported compression error message in toast_compression.c

This code used a NO_LZ4_SUPPORT() macro to issue an error in the codepaths where LZ4 [de]compression is attempted but the build does notsupport it. This commit refactors the code to use a more flexible errormessage so as it can be used for other compression methods, where themethod is given in input of macro.Extracted from a larger patch by the same author.Author: Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>Discussion:https://postgr.es/m/CAFAfj_HX84EK4hyRYw50AOHOcdVi-+FFwAAPo7JHx4aShCvunQ@mail.gmail.com

1 parentb8341ae commit1dbe6f7Copy full SHA for 1dbe6f7

File tree

1 file changed

-7

lines changed

src/backend/access/common
- toast_compression.c

1 file changed

-7

lines changed

`‎src/backend/access/common/toast_compression.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,11 @@`
`25`	`25`	`/* GUC */`
`26`	`26`	`intdefault_toast_compression=TOAST_PGLZ_COMPRESSION;`
`27`	`27`
`28`		`-#defineNO_LZ4_SUPPORT() \`
	`28`	`+#defineNO_COMPRESSION_SUPPORT(method) \`
`29`	`29`	`ereport(ERROR, \`
`30`	`30`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \`
`31`		`- errmsg("compression methodlz4 not supported"), \`
`32`		`- errdetail("This functionality requires the server to be built withlz4 support.")))`
	`31`	`+ errmsg("compression method%s not supported", method), \`
	`32`	`+ errdetail("This functionality requires the server to be built with%s support.", method)))`
`33`	`33`
`34`	`34`	`/*`
`35`	`35`	`* Compress a varlena using PGLZ.`
`@@ -139,7 +139,7 @@ struct varlena *`
`139`	`139`	`lz4_compress_datum(conststructvarlena*value)`
`140`	`140`	`{`
`141`	`141`	`#ifndefUSE_LZ4`
`142`		`-NO_LZ4_SUPPORT();`
	`142`	`+NO_COMPRESSION_SUPPORT("lz4");`
`143`	`143`	`returnNULL;/* keep compiler quiet */`
`144`	`144`	`#else`
`145`	`145`	`int32valsize;`
`@@ -182,7 +182,7 @@ struct varlena *`
`182`	`182`	`lz4_decompress_datum(conststructvarlena*value)`
`183`	`183`	`{`
`184`	`184`	`#ifndefUSE_LZ4`
`185`		`-NO_LZ4_SUPPORT();`
	`185`	`+NO_COMPRESSION_SUPPORT("lz4");`
`186`	`186`	`returnNULL;/* keep compiler quiet */`
`187`	`187`	`#else`
`188`	`188`	`int32rawsize;`
`@@ -215,7 +215,7 @@ struct varlena *`
`215`	`215`	`lz4_decompress_datum_slice(conststructvarlena*value,int32slicelength)`
`216`	`216`	`{`
`217`	`217`	`#ifndefUSE_LZ4`
`218`		`-NO_LZ4_SUPPORT();`
	`218`	`+NO_COMPRESSION_SUPPORT("lz4");`
`219`	`219`	`returnNULL;/* keep compiler quiet */`
`220`	`220`	`#else`
`221`	`221`	`int32rawsize;`
`@@ -289,7 +289,7 @@ CompressionNameToMethod(const char *compression)`
`289`	`289`	`elseif (strcmp(compression,"lz4")==0)`
`290`	`290`	`{`
`291`	`291`	`#ifndefUSE_LZ4`
`292`		`-NO_LZ4_SUPPORT();`
	`292`	`+NO_COMPRESSION_SUPPORT("lz4");`
`293`	`293`	`#endif`
`294`	`294`	`returnTOAST_LZ4_COMPRESSION;`
`295`	`295`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1dbe6f7

File tree

1 file changed

1 file changed

`‎src/backend/access/common/toast_compression.c`

0 commit comments