NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.8k

Commit1d9c5d0

committed

Do not rely on pgstat.h to indirectly include storage/ headers.

An upcoming patch might remove the (now indirect) proc.hinclude (which in turn includes other headers), and it's cleaner forthe modified files to include their dependencies directly anyway...Discussion:https://postgr.es/m/20210402194458.2vu324hkk2djq6ce@alap3.anarazel.de

1 parenta333476 commit1d9c5d0Copy full SHA for 1d9c5d0

File tree

6 files changed

-0

lines changed

contrib/pg_stat_statements
- pg_stat_statements.c
src/backend
- postmaster
  - pgarch.c
  - pgstat.c
- replication
  - walreceiver.c
- storage/lmgr
  - lmgr.c
- utils/adt
  - misc.c

6 files changed

-0

lines changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,8 @@`
`76`	`76`	`#include"pgstat.h"`
`77`	`77`	`#include"storage/fd.h"`
`78`	`78`	`#include"storage/ipc.h"`
	`79`	`+#include"storage/lwlock.h"`
	`80`	`+#include"storage/shmem.h"`
`79`	`81`	`#include"storage/spin.h"`
`80`	`82`	`#include"tcop/utility.h"`
`81`	`83`	`#include"utils/acl.h"`

`‎src/backend/postmaster/pgarch.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@`
`44`	`44`	`#include"storage/ipc.h"`
`45`	`45`	`#include"storage/latch.h"`
`46`	`46`	`#include"storage/pmsignal.h"`
	`47`	`+#include"storage/proc.h"`
`47`	`48`	`#include"storage/procsignal.h"`
	`49`	`+#include"storage/shmem.h"`
`48`	`50`	`#include"utils/guc.h"`
`49`	`51`	`#include"utils/ps_status.h"`
`50`	`52`

`‎src/backend/postmaster/pgstat.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@`
`61`	`61`	`#include"storage/latch.h"`
`62`	`62`	`#include"storage/lmgr.h"`
`63`	`63`	`#include"storage/pg_shmem.h"`
	`64`	`+#include"storage/proc.h"`
`64`	`65`	`#include"storage/procsignal.h"`
`65`	`66`	`#include"storage/sinvaladt.h"`
`66`	`67`	`#include"utils/ascii.h"`

`‎src/backend/replication/walreceiver.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@`
`69`	`69`	`#include"replication/walsender.h"`
`70`	`70`	`#include"storage/ipc.h"`
`71`	`71`	`#include"storage/pmsignal.h"`
	`72`	`+#include"storage/proc.h"`
`72`	`73`	`#include"storage/procarray.h"`
`73`	`74`	`#include"storage/procsignal.h"`
`74`	`75`	`#include"utils/acl.h"`

`‎src/backend/storage/lmgr/lmgr.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`#include"miscadmin.h"`
`24`	`24`	`#include"pgstat.h"`
`25`	`25`	`#include"storage/lmgr.h"`
	`26`	`+#include"storage/proc.h"`
`26`	`27`	`#include"storage/procarray.h"`
`27`	`28`	`#include"storage/sinvaladt.h"`
`28`	`29`	`#include"utils/inval.h"`

`‎src/backend/utils/adt/misc.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@`
`36`	`36`	`#include"postmaster/syslogger.h"`
`37`	`37`	`#include"rewrite/rewriteHandler.h"`
`38`	`38`	`#include"storage/fd.h"`
	`39`	`+#include"storage/latch.h"`
`39`	`40`	`#include"tcop/tcopprot.h"`
`40`	`41`	`#include"utils/builtins.h"`
`41`	`42`	`#include"utils/fmgroids.h"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1d9c5d0

File tree

6 files changed

6 files changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

`‎src/backend/postmaster/pgarch.c`

`‎src/backend/postmaster/pgstat.c`

`‎src/backend/replication/walreceiver.c`

`‎src/backend/storage/lmgr/lmgr.c`

`‎src/backend/utils/adt/misc.c`

0 commit comments