NotificationsYou must be signed in to change notification settings
Fork5.3k
Star19.2k

Commit1cdb84b

committed

Check for correct version of perltidy

pgperltidy requires a particular version of perltidy, but the versionwasn't checked like how pgindent checks the underlying indent binary.Fix by checking the version of perltidy and error out if an incorrectversion is used.Author: Daniel Gustafsson <daniel@yesql.se>Reported-by: Tom Lane <tgl@sss.pgh.pa.us>Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Reviewed-by: Andrew Dunstan <andrew@dunslane.net>Discussion:https://postgr.es/m/1209850.1764092152@sss.pgh.pa.us

1 parent8d29905 commit1cdb84bCopy full SHA for 1cdb84b

File tree

1 file changed

-0

lines changed

src/tools/pgindent
- pgperltidy

1 file changed

-0

lines changed

`‎src/tools/pgindent/pgperltidy‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,12 @@ set -e`
`7`	`7`	`# set this to override default perltidy program:`
`8`	`8`	`PERLTIDY=${PERLTIDY:-perltidy}`
`9`	`9`
	`10`	`+PERLTIDY_VERSION=20230309`
	`11`	`+if!$PERLTIDY -v\| grep -q$PERLTIDY_VERSION;then`
	`12`	`+echo"You do not appear to have$PERLTIDY version$PERLTIDY_VERSION installed on your system.">&2`
	`13`	`+exit 1`
	`14`	`+fi`
	`15`	`+`
`10`	`16`	`. src/tools/perlcheck/find_perl_files`
`11`	`17`
`12`	`18`	`find_perl_files"$@"\| xargs$PERLTIDY --profile=src/tools/pgindent/perltidyrc`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1cdb84b

File tree

1 file changed

1 file changed

`‎src/tools/pgindent/pgperltidy‎`

0 commit comments