Commit1bdd54e

committed

Remove redundant call to pgstat_report_wal()

pgstat_report_stat() will be called before shutdown so an explicit call topgstat_report_wal() just before shutdown is redundant.This likely was not redundant before5891c7a, but now it clearly is.Author: Melanie Plageman <melanieplageman@gmail.com>Reviewed-by: Andres Freund <andres@anarazel.de>Discussion:https://www.postgresql.org/message-id/CAAKRu_aaq33UnG4TXq3S-OSXGWj1QGf0sU%2BECH4tNwGFNERkZA%40mail.gmail.com

1 parent0c67946 commit1bdd54eCopy full SHA for 1bdd54e

File tree

-11

lines changed

-11

lines changed

Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -293,18 +293,7 @@ HandleWalWriterInterrupts(void)`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`if (ShutdownRequestPending)`
`296`		`-{`
`297`		`-/*`
`298`		`- * Force reporting remaining WAL statistics at process exit.`
`299`		`- *`
`300`		`- * Since pgstat_report_wal is invoked with 'force' is false in main`
`301`		`- * loop to avoid overloading the cumulative stats system, there may`
`302`		`- * exist unreported stats counters for the WAL writer.`
`303`		`- */`
`304`		`-pgstat_report_wal(true);`
`305`		`-`
`306`	`296`	`proc_exit(0);`
`307`		`-}`
`308`	`297`
`309`	`298`	`/* Perform logging of memory contexts of this process */`
`310`	`299`	`if (LogMemoryContextPending)`

Comments

(0)