Commit1b7f516

Michael Meskes

committed

Return error if allocation of new element was not possible.

Found by Coverity.

1 parent0caf562 commit1b7f516Copy full SHA for 1b7f516

File tree

-2

lines changed

-2

lines changed

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -402,14 +402,18 @@ PGTYPESnumeric_to_asc(numeric *num, int dscale)`
`402`	`402`	`numeric*numcopy=PGTYPESnumeric_new();`
`403`	`403`	`char*s;`
`404`	`404`
`405`		`-if (dscale<0)`
`406`		`-dscale=num->dscale;`
	`405`	`+if (numcopy==NULL)`
	`406`	`+returnNULL;`
`407`	`407`
`408`	`408`	`if (PGTYPESnumeric_copy(num,numcopy)<0)`
`409`	`409`	`{`
`410`	`410`	`PGTYPESnumeric_free(numcopy);`
`411`	`411`	`returnNULL;`
`412`	`412`	`}`
	`413`	`+`
	`414`	`+if (dscale<0)`
	`415`	`+dscale=num->dscale;`
	`416`	`+`
`413`	`417`	`/* get_str_from_var may change its argument */`
`414`	`418`	`s=get_str_from_var(numcopy,dscale);`
`415`	`419`	`PGTYPESnumeric_free(numcopy);`
`@@ -1493,6 +1497,9 @@ numericvar_to_double(numeric var, double dp)`
`1493`	`1497`	`char*endptr;`
`1494`	`1498`	`numeric*varcopy=PGTYPESnumeric_new();`
`1495`	`1499`
	`1500`	`+if (varcopy==NULL)`
	`1501`	`+return-1;`
	`1502`	`+`
`1496`	`1503`	`if (PGTYPESnumeric_copy(var,varcopy)<0)`
`1497`	`1504`	`{`
`1498`	`1505`	`PGTYPESnumeric_free(varcopy);`

Comments

(0)