Commit1b2c294

committed

Fix HashAgg regression from choosing too many initial buckets.

1 parent47c7187 commit1b2c294Copy full SHA for 1b2c294

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -294,9 +294,6 @@`
`294`	`294`	`#defineHASHAGG_READ_BUFFER_SIZE BLCKSZ`
`295`	`295`	`#defineHASHAGG_WRITE_BUFFER_SIZE BLCKSZ`
`296`	`296`
`297`		`-/* minimum number of initial hash table buckets */`
`298`		`-#defineHASHAGG_MIN_BUCKETS 256`
`299`		`-`
`300`	`297`	`/*`
`301`	`298`	`* Estimate chunk overhead as a constant 16 bytes. XXX: should this be`
`302`	`299`	`* improved?`
`@@ -1926,9 +1923,8 @@ hash_choose_num_buckets(double hashentrysize, long ngroups, Size memory)`
`1926`	`1923`
`1927`	`1924`	`if (nbuckets>max_nbuckets)`
`1928`	`1925`	`nbuckets=max_nbuckets;`
`1929`		`-if (nbuckets<HASHAGG_MIN_BUCKETS)`
`1930`		`-nbuckets=HASHAGG_MIN_BUCKETS;`
`1931`		`-returnnbuckets;`
	`1926`	`+`
	`1927`	`+returnMax(nbuckets,1);`
`1932`	`1928`	`}`
`1933`	`1929`
`1934`	`1930`	`/*`

Comments

(0)