NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit14ce78e

committed

Recurse to sequences on ownership change for all relkinds

When a table ownership is changed, we must apply that also to any ownedsequences. (Otherwise, it would result in a situation that cannot berestored, because linked sequences must have the same owner as thetable.) But this was previously only applied to regular tables andmaterialized views. But it should also apply to at least foreigntables. This patch removes the relkind check altogether, because itdoesn't save very much and just introduces the possibility of similaromissions.Bug: #15238Reported-by: Christoph Berg <christoph.berg@credativ.de>

1 parent6019247 commit14ce78eCopy full SHA for 14ce78e

File tree

1 file changed

-10

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-10

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 6 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -8431,17 +8431,13 @@ ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, LOCKMODE lock`
`8431`	`8431`	`list_free(index_oid_list);`
`8432`	`8432`	`}`
`8433`	`8433`
`8434`		`-if (tuple_class->relkind==RELKIND_RELATION\|\|`
`8435`		`-tuple_class->relkind==RELKIND_MATVIEW)`
`8436`		`-{`
`8437`		`-/* If it has a toast table, recurse to change its ownership */`
`8438`		`-if (tuple_class->reltoastrelid!=InvalidOid)`
`8439`		`-ATExecChangeOwner(tuple_class->reltoastrelid,newOwnerId,`
`8440`		`- true,lockmode);`
	`8434`	`+/* If it has a toast table, recurse to change its ownership */`
	`8435`	`+if (tuple_class->reltoastrelid!=InvalidOid)`
	`8436`	`+ATExecChangeOwner(tuple_class->reltoastrelid,newOwnerId,`
	`8437`	`+ true,lockmode);`
`8441`	`8438`
`8442`		`-/* If it has dependent sequences, recurse to change them too */`
`8443`		`-change_owner_recurse_to_sequences(relationOid,newOwnerId,lockmode);`
`8444`		`-}`
	`8439`	`+/* If it has dependent sequences, recurse to change them too */`
	`8440`	`+change_owner_recurse_to_sequences(relationOid,newOwnerId,lockmode);`
`8445`	`8441`	`}`
`8446`	`8442`
`8447`	`8443`	`InvokeObjectPostAlterHook(RelationRelationId,relationOid,0);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit14ce78e

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments