NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit1046dbe

committed

Silence another gcc 11 warning.

Per buildfarm and local experimentation, bleeding-edge gcc isn'tconvinced that the MemSet in reorder_function_arguments() is safe.Shut it up by adding an explicit check that pronargs isn't negative,and by changing MemSet to memset. (It appears that either change isenough to quiet the warning at -O2, but let's do both to be sure.)

1 parent6f5c8a8 commit1046dbeCopy full SHA for 1046dbe

File tree

1 file changed

-2

lines changed

src/backend/optimizer/util
- clauses.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/util/clauses.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3805,9 +3805,9 @@ reorder_function_arguments(List *args, HeapTuple func_tuple)`
`3805`	`3805`	`inti;`
`3806`	`3806`
`3807`	`3807`	`Assert(nargsprovided <=pronargs);`
`3808`		`-if (pronargs>FUNC_MAX_ARGS)`
	`3808`	`+if (pronargs<0\|\|pronargs>FUNC_MAX_ARGS)`
`3809`	`3809`	`elog(ERROR,"too many function arguments");`
`3810`		`-MemSet(argarray,0,pronargssizeof(Node));`
	`3810`	`+memset(argarray,0,pronargssizeof(Node));`
`3811`	`3811`
`3812`	`3812`	`/* Deconstruct the argument list into an array indexed by argnumber */`
`3813`	`3813`	`i=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1046dbe

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/clauses.c`

0 commit comments