Commit0fd8cfb

committed

GetPublicationByName: Don't repeat ourselves

Use get_publication_oid() instead of reimplementing it.Discussion:https://postgr.es/m/20191220201017.GA17292@alvherre.pgsql

1 parent696cc3a commit0fd8cfbCopy full SHA for 0fd8cfb

File tree

-13

lines changed

-13

lines changed

Lines changed: 2 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,6 @@ GetPublication(Oid pubid)`
`374`	`374`	`Form_pg_publicationpubform;`
`375`	`375`
`376`	`376`	`tup=SearchSysCache1(PUBLICATIONOID,ObjectIdGetDatum(pubid));`
`377`		`-`
`378`	`377`	`if (!HeapTupleIsValid(tup))`
`379`	`378`	`elog(ERROR,"cache lookup failed for publication %u",pubid);`
`380`	`379`
`@@ -403,19 +402,9 @@ GetPublicationByName(const char *pubname, bool missing_ok)`
`403`	`402`	`{`
`404`	`403`	`Oidoid;`
`405`	`404`
`406`		`-oid=GetSysCacheOid1(PUBLICATIONNAME,Anum_pg_publication_oid,`
`407`		`-CStringGetDatum(pubname));`
`408`		`-if (!OidIsValid(oid))`
`409`		`-{`
`410`		`-if (missing_ok)`
`411`		`-returnNULL;`
`412`		`-`
`413`		`-ereport(ERROR,`
`414`		`-(errcode(ERRCODE_UNDEFINED_OBJECT),`
`415`		`-errmsg("publication \"%s\" does not exist",pubname)));`
`416`		`-}`
	`405`	`+oid=get_publication_oid(pubname,missing_ok);`
`417`	`406`
`418`		`-returnGetPublication(oid);`
	`407`	`+returnOidIsValid(oid) ?GetPublication(oid) :NULL;`
`419`	`408`	`}`
`420`	`409`
`421`	`410`	`/*`

Comments

(0)