NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.8k

Commit0f1433f

committed

Fix a few oversights in the longer cancel keys patch

Change MyCancelKeyLength's type from uint8 to int. While it alwaysfits in a uint8, plain int is less surprising, as there's noparticular reason for it to be uint8.Fix one ProcSignalInit caller that passed 'false' instead of NULL forthe pointer argument.Author: Peter Eisentraut <peter@eisentraut.org>Discussion:https://www.postgresql.org/message-id/61be9e31-7b7d-49d5-bc11-721800d89d64@eisentraut.org

1 parentef366b7 commit0f1433fCopy full SHA for 0f1433f

File tree

3 files changed

-3

lines changed

src
- backend
  - postmaster
    - auxprocess.c
  - utils/init
    - globals.c
- include
  - miscadmin.h

3 files changed

-3

lines changed

`‎src/backend/postmaster/auxprocess.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ AuxiliaryProcessMainCommon(void)`
`66`	`66`
`67`	`67`	`BaseInit();`
`68`	`68`
`69`		`-ProcSignalInit(false,0);`
	`69`	`+ProcSignalInit(NULL,0);`
`70`	`70`
`71`	`71`	`/*`
`72`	`72`	`* Auxiliary processes don't run transactions, but they may need a`

`‎src/backend/utils/init/globals.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ TimestampTz MyStartTimestamp;`
`51`	`51`	`structClientSocket*MyClientSocket;`
`52`	`52`	`structPort*MyProcPort;`
`53`	`53`	`charMyCancelKey[MAX_CANCEL_KEY_LENGTH];`
`54`		`-uint8MyCancelKeyLength=0;`
	`54`	`+intMyCancelKeyLength=0;`
`55`	`55`	`intMyPMChildSlot;`
`56`	`56`
`57`	`57`	`/*`

`‎src/include/miscadmin.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ extern PGDLLIMPORT TimestampTz MyStartTimestamp;`
`193`	`193`	`externPGDLLIMPORTstructPort*MyProcPort;`
`194`	`194`	`externPGDLLIMPORTstructLatch*MyLatch;`
`195`	`195`	`externPGDLLIMPORTcharMyCancelKey[];`
`196`		`-externPGDLLIMPORTuint8MyCancelKeyLength;`
	`196`	`+externPGDLLIMPORTintMyCancelKeyLength;`
`197`	`197`	`externPGDLLIMPORTintMyPMChildSlot;`
`198`	`198`
`199`	`199`	`externPGDLLIMPORTcharOutputFileName[];`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0f1433f

File tree

3 files changed

3 files changed

`‎src/backend/postmaster/auxprocess.c`

`‎src/backend/utils/init/globals.c`

`‎src/include/miscadmin.h`

0 commit comments