NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit0c09922

committed

Adjust regex for test with opening parenthesis in character classes

As written, the test was throwing an error because of an unbalancedparenthesis. The regex used in the test is adjusted to not fail and totest the case of an opening parenthesis in a character class after somenested square brackets.Oversight ind46911e.Discussion:https://postgr.es/m/16ab039d1af455652bdf4173402ddda145f2c73b.camel@cybertec.at

1 parent1fe15d2 commit0c09922Copy full SHA for 0c09922

File tree

2 files changed

-3

lines changed

src/test/regress
- expected
  - strings.out
- sql
  - strings.sql

2 files changed

-3

lines changed

`‎src/test/regress/expected/strings.out`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -599,8 +599,13 @@ EXPLAIN (COSTS OFF) SELECT * FROM TEXT_TBL WHERE f1 SIMILAR TO '$[$[:alnum:]$]$'`
`599`	`599`	`(2 rows)`
`600`	`600`
`601`	`601`	`-- Opening parenthesis "("`
`602`		`-EXPLAIN (COSTS OFF) SELECT * FROM TEXT_TBL WHERE f1 SIMILAR TO '([([:alnum:](](';`
`603`		`-ERROR: invalid regular expression: parentheses () not balanced`
	`602`	`+EXPLAIN (COSTS OFF) SELECT * FROM TEXT_TBL WHERE f1 SIMILAR TO '()[([:alnum:](]()';`
	`603`	`+ QUERY PLAN`
	`604`	`+------------------------------------------------------`
	`605`	`+ Seq Scan on text_tbl`
	`606`	`+ Filter: (f1 ~ '^(?:(?:)[([:alnum:](](?:))$'::text)`
	`607`	`+(2 rows)`
	`608`	`+`
`604`	`609`	`-- Caret "^"`
`605`	`610`	`EXPLAIN (COSTS OFF) SELECT * FROM TEXT_TBL WHERE f1 SIMILAR TO '^[^[:alnum:]^[^^][[^^]][\^][[\^]]\^]^';`
`606`	`611`	`QUERY PLAN`

`‎src/test/regress/sql/strings.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ EXPLAIN (COSTS OFF) SELECT * FROM TEXT_TBL WHERE f1 SIMILAR TO '.[.[:alnum:].].'`
`196`	`196`	`-- Dollar "$"`
`197`	`197`	`EXPLAIN (COSTS OFF)SELECT*FROM TEXT_TBLWHERE f1 SIMILAR TO'$[$[:alnum:]$]$';`
`198`	`198`	`-- Opening parenthesis "("`
`199`		`-EXPLAIN (COSTS OFF)SELECT*FROM TEXT_TBLWHERE f1 SIMILAR TO'([([:alnum:](](';`
	`199`	`+EXPLAIN (COSTS OFF)SELECT*FROM TEXT_TBLWHERE f1 SIMILAR TO'()[([:alnum:](]()';`
`200`	`200`	`-- Caret "^"`
`201`	`201`	`EXPLAIN (COSTS OFF)SELECT*FROM TEXT_TBLWHERE f1 SIMILAR TO'^[^[:alnum:]^[^^][[^^]][\^][[\^]]\^]^';`
`202`	`202`	`-- Closing square bracket "]" at the beginning of character class`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0c09922

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/strings.out`

`‎src/test/regress/sql/strings.sql`

0 commit comments