Commit0a40563

committed

Disallow factorial of negative numbers

The previous implementation returned 1 for all negative numbers, whichis not sensible under any definition.Discussion:https://www.postgresql.org/message-id/flat/6ce1df0e-86a3-e544-743a-f357ff663f68%402ndquadrant.com

1 parent9d402c7 commit0a40563Copy full SHA for 0a40563

File tree

-10

lines changed

-10

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2946,6 +2946,10 @@ numeric_fac(PG_FUNCTION_ARGS)`
`2946`	`2946`	`NumericVarfact;`
`2947`	`2947`	`NumericVarresult;`
`2948`	`2948`
	`2949`	`+if (num<0)`
	`2950`	`+ereport(ERROR,`
	`2951`	`+(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),`
	`2952`	`+errmsg("factorial of a negative number is undefined")));`
`2949`	`2953`	`if (num <=1)`
`2950`	`2954`	`{`
`2951`	`2955`	`res=make_result(&const_one);`

Lines changed: 2 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -2345,14 +2345,6 @@ SELECT 0!;`
`2345`	`2345`	`(1 row)`
`2346`	`2346`
`2347`	`2347`	`SELECT -4!;`
`2348`		`- ?column?`
`2349`		`-----------`
`2350`		`- 1`
`2351`		`-(1 row)`
`2352`		`-`
	`2348`	`+ERROR: factorial of a negative number is undefined`
`2353`	`2349`	`SELECT factorial(-4);`
`2354`		`- factorial`
`2355`		`------------`
`2356`		`- 1`
`2357`		`-(1 row)`
`2358`		`-`
	`2350`	`+ERROR: factorial of a negative number is undefined`

Comments

(0)