NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commit087a933

committed

Remove expensive test of postgres_fdw batch inserts

The test inserted 70k rows into a foreign table, in order to verifycorrect behavior with more than 65535 parameters, and was added inresponse to a bug report.However, this is rather expensive, especially when running the testsunder valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it tokeep running the test, so remove it from all branches (14+).Backpatch-through: 14Discussion:https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us

1 parent9436535 commit087a933Copy full SHA for 087a933

File tree

2 files changed

-18

lines changed

contrib/postgres_fdw
- expected
  - postgres_fdw.out
- sql
  - postgres_fdw.sql

2 files changed

-18

lines changed

`‎contrib/postgres_fdw/expected/postgres_fdw.out‎`

Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -10346,17 +10346,6 @@ SELECT COUNT(*) FROM ftable;`
`10346`	`10346`	`34`
`10347`	`10347`	`(1 row)`
`10348`	`10348`
`10349`		`-TRUNCATE batch_table;`
`10350`		`-DROP FOREIGN TABLE ftable;`
`10351`		`--- try if large batches exceed max number of bind parameters`
`10352`		`-CREATE FOREIGN TABLE ftable ( x int ) SERVER loopback OPTIONS ( table_name 'batch_table', batch_size '100000' );`
`10353`		`-INSERT INTO ftable SELECT * FROM generate_series(1, 70000) i;`
`10354`		`-SELECT COUNT(*) FROM ftable;`
`10355`		`- count`
`10356`		`--------`
`10357`		`- 70000`
`10358`		`-(1 row)`
`10359`		`-`
`10360`	`10349`	`TRUNCATE batch_table;`
`10361`	`10350`	`DROP FOREIGN TABLE ftable;`
`10362`	`10351`	`-- Disable batch insert`

`‎contrib/postgres_fdw/sql/postgres_fdw.sql‎`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -3341,13 +3341,6 @@ SELECT COUNT(*) FROM ftable;`
`3341`	`3341`	`TRUNCATE batch_table;`
`3342`	`3342`	`DROP FOREIGN TABLE ftable;`
`3343`	`3343`
`3344`		`--- try if large batches exceed max number of bind parameters`
`3345`		`-CREATE FOREIGN TABLE ftable ( xint ) SERVER loopback OPTIONS ( table_name'batch_table', batch_size'100000' );`
`3346`		`-INSERT INTO ftableSELECT*FROM generate_series(1,70000) i;`
`3347`		`-SELECTCOUNT(*)FROM ftable;`
`3348`		`-TRUNCATE batch_table;`
`3349`		`-DROP FOREIGN TABLE ftable;`
`3350`		`-`
`3351`	`3344`	`-- Disable batch insert`
`3352`	`3345`	`CREATE FOREIGN TABLE ftable ( xint ) SERVER loopback OPTIONS ( table_name'batch_table', batch_size'1' );`
`3353`	`3346`	`EXPLAIN (VERBOSE, COSTS OFF)INSERT INTO ftableVALUES (1), (2);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit087a933

File tree

2 files changed

2 files changed

`‎contrib/postgres_fdw/expected/postgres_fdw.out‎`

`‎contrib/postgres_fdw/sql/postgres_fdw.sql‎`

0 commit comments