NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit0832f2d

committed

Fix latent costing error in create_merge_append_path.

create_merge_append_path should use the path rowcount it just computed,not rel->tuples, for costing purposes. Those numbers should always bethe same at present, but if we ever support parameterized MergeAppendpaths (a case this function is otherwise prepared for), the former wouldbe right and the latter wrong.No need for back-patch since the problem is only latent.Ashutosh BapatDiscussion: <CAFjFpRek+cLCnTo24youuGtsq4zRphEB8EUUPjDxZjnL4n4HYQ@mail.gmail.com>

1 parent13671b4 commit0832f2dCopy full SHA for 0832f2d

File tree

1 file changed

-1

lines changed

src/backend/optimizer/util
- pathnode.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/util/pathnode.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1333,7 +1333,7 @@ create_merge_append_path(PlannerInfo *root,`
`1333`	`1333`	`cost_merge_append(&pathnode->path,root,`
`1334`	`1334`	`pathkeys,list_length(subpaths),`
`1335`	`1335`	`input_startup_cost,input_total_cost,`
`1336`		`-rel->tuples);`
	`1336`	`+pathnode->path.rows);`
`1337`	`1337`
`1338`	`1338`	`returnpathnode;`
`1339`	`1339`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0832f2d

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/pathnode.c`

0 commit comments