NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.8k

Commit06be01e

committed

Fix instable 006_login_trigger.pl test

Handling of login trigger FATAL error could cause a timing-dependant panic ofIPC::Run. This commit excludes checks which involves handling of such errors.Reported-by: Tom LaneDiscussion:https://postgr.es/m/2268825.1698618066%40sss.pgh.pa.us

1 parent5ba4cc3 commit06be01eCopy full SHA for 06be01e

File tree

1 file changed

-14

lines changed

src/test/authentication/t
- 006_login_trigger.pl

1 file changed

-14

lines changed

`‎src/test/authentication/t/006_login_trigger.pl`

Lines changed: 3 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -143,27 +143,16 @@ BEGIN`
`143`	`143`	`log_exact=>'2',`
`144`	`144`	`err_like=> [qr/You are welcome/]);`
`145`	`145`
`146`		`-# Try to log as allowed Alice and disallowed Mallory (two times)`
	`146`	`+# Try to login as allowed Alice. We don't check the Mallroy login, because`
	`147`	`+# FATAL error could cause a timing-dependant panic of IPC::Run.`
`147`	`148`	`psql_command(`
`148`	`149`	`$node,'SELECT 1;', 0,'try regress_alice',`
`149`	`150`	`connstr=>'user=regress_alice',`
`150`	`151`	`log_exact=>'1',`
`151`	`152`	`err_like=> [qr/You are welcome/],`
`152`	`153`	`err_unlike=> [qr/You are NOT welcome/]);`
`153`		`-psql_command(`
`154`		`-$node,'SELECT 1;', 2,'try regress_mallory',`
`155`		`-connstr=>'user=regress_mallory',`
`156`		`-log_exact=>'',`
`157`		`-err_like=> [qr/You are NOT welcome/],`
`158`		`-err_unlike=> [qr/You are welcome/]);`
`159`		`-psql_command(`
`160`		`-$node,'SELECT 1;', 2,'try regress_mallory',`
`161`		`-connstr=>'user=regress_mallory',`
`162`		`-log_exact=>'',`
`163`		`-err_like=> [qr/You are NOT welcome/],`
`164`		`-err_unlike=> [qr/You are welcome/]);`
`165`	`154`
`166`		`-# Check that Alice's login record is here, while the Mallory's one is not`
	`155`	`+# Check that Alice's login record is here`
`167`	`156`	`psql_command(`
`168`	`157`	`$node,'SELECT * FROM user_logins;', 0,'select *',`
`169`	`158`	`log_like=> [qr/3\\|regress_alice/],`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit06be01e

File tree

1 file changed

1 file changed

`‎src/test/authentication/t/006_login_trigger.pl`

0 commit comments