NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit05dea24

committed

Repair unstable regression test.

Commit0c882e5 tried to force table atest12 to have more-accurate-than-default statistics; but transiently setting default_statistics_targetisn't enough for that, because autovacuum could come along and overwritethe stats later. This evidently explains some intermittent buildfarmfailures we've seen since then. Repair by disabling autovac on this table.Thanks to David Rowley for correctly diagnosing the cause.Discussion:https://postgr.es/m/CA+hUKG+OUkQSOUTg=qo=S=fWa_tbm99i7rB7mfbHz1SYm4v-jQ@mail.gmail.com

1 parent1b2c294 commit05dea24Copy full SHA for 05dea24

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - privileges.out
- sql
  - privileges.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/privileges.out`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,8 @@ CREATE TABLE atest12 as`
`191`	`191`	`SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x;`
`192`	`192`	`CREATE INDEX ON atest12 (a);`
`193`	`193`	`CREATE INDEX ON atest12 (abs(a));`
`194`		`--- results below depend on having quite accurate stats for atest12`
	`194`	`+-- results below depend on having quite accurate stats for atest12, so...`
	`195`	`+ALTER TABLE atest12 SET (autovacuum_enabled = off);`
`195`	`196`	`SET default_statistics_target = 10000;`
`196`	`197`	`VACUUM ANALYZE atest12;`
`197`	`198`	`RESET default_statistics_target;`

`‎src/test/regress/sql/privileges.sql`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,8 @@ CREATE TABLE atest12 as`
`136`	`136`	`SELECT xAS a,10001- xAS bFROM generate_series(1,10000) x;`
`137`	`137`	`CREATEINDEXON atest12 (a);`
`138`	`138`	`CREATEINDEXON atest12 (abs(a));`
`139`		`--- results below depend on having quite accurate stats for atest12`
	`139`	`+-- results below depend on having quite accurate stats for atest12, so...`
	`140`	`+ALTERTABLE atest12SET (autovacuum_enabled= off);`
`140`	`141`	`SET default_statistics_target=10000;`
`141`	`142`	`VACUUM ANALYZE atest12;`
`142`	`143`	`RESET default_statistics_target;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit05dea24

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/privileges.out`

`‎src/test/regress/sql/privileges.sql`

0 commit comments