Commit049ef33

committed

Don't try to open visibilitymap when analyzing a foreign table

It's harmless, visibilitymap_count() returns 0 if the file doesn'texist. But it's also very pointless. I noticed this when I added anassertion in smgropen() that the relnumber is valid.Discussion:https://www.postgresql.org/message-id/621a52fd-3cd8-4f5d-a561-d510b853bbaf@iki.fi

1 parentcd7f19d commit049ef33Copy full SHA for 049ef33

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,10 @@ do_analyze_rel(Relation onerel, VacuumParams *params,`
`634`	`634`	`{`
`635`	`635`	`BlockNumberrelallvisible;`
`636`	`636`
`637`		`-visibilitymap_count(onerel,&relallvisible,NULL);`
	`637`	`+if (RELKIND_HAS_STORAGE(onerel->rd_rel->relkind))`
	`638`	`+visibilitymap_count(onerel,&relallvisible,NULL);`
	`639`	`+else`
	`640`	`+relallvisible=0;`
`638`	`641`
`639`	`642`	`/* Update pg_class for table relation */`
`640`	`643`	`vac_update_relstats(onerel,`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,6 +153,8 @@ smgropen(RelFileLocator rlocator, BackendId backend)`
`153`	`153`	`SMgrRelationreln;`
`154`	`154`	`boolfound;`
`155`	`155`
	`156`	`+Assert(RelFileNumberIsValid(rlocator.relNumber));`
	`157`	`+`
`156`	`158`	`if (SMgrRelationHash==NULL)`
`157`	`159`	`{`
`158`	`160`	`/* First time through: initialize the hash table */`

Comments

(0)