NotificationsYou must be signed in to change notification settings
Fork5k
Star17.9k

Commit00b52c3

committed

Simplify EXPLAIN code for Memoize

This removes a needless special case for Memoize's FORMAT TEXT EXPLAINoutput.ExplainPropertyText() outputs the same thing in text mode as thespecial-case code was doing, so removing the special-case code results inthe same EXPLAIN output, just with less code.It seems like a good idea to fix this to help prevent future changes inthis area from copying the same pattern.Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>Reported-by: David Rowley <dgrowleyml@gmail.com>Discussion:https://postgr.es/m/88a71bcd-0b5c-4d0b-8107-757e96f402d5@tantorlabs.com

1 parent202b127 commit00b52c3Copy full SHA for 00b52c3

File tree

1 file changed

-12

lines changed

src/backend/commands
- explain.c

1 file changed

-12

lines changed

`‎src/backend/commands/explain.c`

Lines changed: 2 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -3625,18 +3625,8 @@ show_memoize_info(MemoizeState mstate, List ancestors, ExplainState *es)`
`3625`	`3625`	`separator=", ";`
`3626`	`3626`	`}`
`3627`	`3627`
`3628`		`-if (es->format!=EXPLAIN_FORMAT_TEXT)`
`3629`		`-{`
`3630`		`-ExplainPropertyText("Cache Key",keystr.data,es);`
`3631`		`-ExplainPropertyText("Cache Mode",mstate->binary_mode ?"binary" :"logical",es);`
`3632`		`-}`
`3633`		`-else`
`3634`		`-{`
`3635`		`-ExplainIndentText(es);`
`3636`		`-appendStringInfo(es->str,"Cache Key: %s\n",keystr.data);`
`3637`		`-ExplainIndentText(es);`
`3638`		`-appendStringInfo(es->str,"Cache Mode: %s\n",mstate->binary_mode ?"binary" :"logical");`
`3639`		`-}`
	`3628`	`+ExplainPropertyText("Cache Key",keystr.data,es);`
	`3629`	`+ExplainPropertyText("Cache Mode",mstate->binary_mode ?"binary" :"logical",es);`
`3640`	`3630`
`3641`	`3631`	`pfree(keystr.data);`
`3642`	`3632`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit00b52c3

File tree

1 file changed

1 file changed

`‎src/backend/commands/explain.c`

0 commit comments