NotificationsYou must be signed in to change notification settings
Fork5k
Star18.1k

Commit006fc97

committed

Fix comments in index.c

This comment paragraph referred to text_eq(), but the name of thefunction in charge of "text" comparisons is called texteq().Author: Jian He <jian.universality@gmail.com>Discussion:https://postgr.es/m/CACJufxHL--XNcCCO1LgKsygzYGiVHZMfTcAxOSG8+ezxWtjddw@mail.gmail.com

1 parent88a658a commit006fc97Copy full SHA for 006fc97

File tree

1 file changed

-4

lines changed

src/backend/catalog
- index.c

1 file changed

-4

lines changed

`‎src/backend/catalog/index.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -800,11 +800,11 @@ index_create(Relation heapRelation,`
`800`	`800`	`errmsg("user-defined indexes on system catalog tables are not supported")));`
`801`	`801`
`802`	`802`	`/*`
`803`		`- * Btree text_pattern_ops usestext_eq as the equality operator, which is`
`804`		`- * fine as long as the collation is deterministic;text_eq then reduces to`
	`803`	`+ * Btree text_pattern_ops usestexteq as the equality operator, which is`
	`804`	`+ * fine as long as the collation is deterministic;texteq then reduces to`
`805`	`805`	`* bitwise equality and so it is semantically compatible with the other`
`806`	`806`	`* operators and functions in that opclass. But with a nondeterministic`
`807`		`- * collation,text_eq could yield results that are incompatible with the`
	`807`	`+ * collation,texteq could yield results that are incompatible with the`
`808`	`808`	`* actual behavior of the index (which is determined by the opclass's`
`809`	`809`	`* comparison function). We prevent such problems by refusing creation of`
`810`	`810`	`* an index with that opclass and a nondeterministic collation.`
`@@ -814,7 +814,7 @@ index_create(Relation heapRelation,`
`814`	`814`	`* opclasses as incompatible with nondeterminism; but for now, this small`
`815`	`815`	`* hack suffices.`
`816`	`816`	`*`
`817`		`- * Another solution is to use a special operator, nottext_eq, as the`
	`817`	`+ * Another solution is to use a special operator, nottexteq, as the`
`818`	`818`	`* equality opclass member; but that is undesirable because it would`
`819`	`819`	`* prevent index usage in many queries that work fine today.`
`820`	`820`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit006fc97

File tree

1 file changed

1 file changed

`‎src/backend/catalog/index.c`

0 commit comments