- Notifications
You must be signed in to change notification settings - Fork12
Introduce Workflow#65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
polobo wants to merge2 commits intopostgres:mainChoose a base branch frompolobo:introduce-workflow
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Introductory material to understand how the workflow operates andits terminology and concepts in the software development domaincompared to generic project managed.Includes a schedule.Also add a reference guide.
The Commitfest Workflow is a formalization and extension of the existingcommitfest-only protocol. There is now some in-app documentation and theidea of moving patches to the "next CF" has begun being deprecated. Insteadthe UI provides the user valid choices on where to transition patches,which, with the introduction of the Drafts commitfest, is basically oneor the other. Committers gain the ability to transition patches intoIn Progress if desired. Patches within In Progress commitfests canbe moved into either Open or Drafts. Begin enforcement of a maximumof one commifest in each of Parked, Open, and In Progress.The workflow defines the drafts commitfest as lasting for one yearmatching up with the major release process. Namely, once thecommifest leading up to feature freeze is In Progress a newDrafts commitfest should be created.With the workflow changes it is necessary for CFBot to be made awareof the specific commitfest ids that are active. Provide a JSON APIfor this purpose to begin weaning CFBot off scraping html.The workflow in-app documentation includes a month-based scheduleshowing which commifests are active, and their names, in each month(among other related details). Begin enforcing the existing rulethat future commitfests cannot have patches via triggers. Futurework on the administrative and UX aspects of the CFApp likely willdo away with future commitfests altogether. Thoughts on the topicare welcome in the GitHub issues.
operations = [ | ||
migrations.RunSQL( | ||
""" | ||
CREATE FUNCTION assert_poc_not_future_for_poc() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As also said on the previous PR: Instead of messing around with triggers. We should simply remove the concept of future commitfests.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a much pared down version of PR#62 . Please review that message for the big picture of where all of this is going.
For this PR the goal is to start down the path to improved UX and CFBot integration through formalization of existing processes, exposing an API, and adding the Parked/Drafts commitfest status. See the commit messages for more details.