- Notifications
You must be signed in to change notification settings - Fork12
Adjust direction of dropdowns at the bottom of the page#4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
media/commitfest/css/commitfest.css Outdated
| @@ -37,7 +37,10 @@ div.form-group div.controls input.threadpick-input { | |||
| display: inline; | |||
| } | |||
| .dropdown-menu--up { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of creating a custom class, it seems you can use thedropup class that's built into bootstrap instead (it's already used incommitfest.html). That also makes the caret point up. Other than that I think it's good thedropdown_mode thing seems to work well to isolate this to only the bottom of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, that's very nice! Updated.
| @@ -183,7 +183,9 @@ <h4>Annotations</h4> | |||
| </tbody> | |||
| </table> | |||
| {% with dropdown_mode="dropup" %} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After sleeping on this, I think if you make this a<div> you get the same effect without having to changepatch_commands.inc at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ha, that works! Very clean. :)
The bottom dropdowns on the patch page would expand downwards, requiringthe user to scroll down to see and click any of the buttons in the dropdown.With this change these are changed into "dropup" menus, so the expand upwards.
The bottom dropdowns on the patch page would expand downwards, requiringthe user to scroll down to see and click any of the buttons in the dropdown.With this change these are changed into "dropup" menus, so the expand upwards.
The bottom dropdowns on the patch page would expand downwards, requiringthe user to scroll down to see and click any of the buttons in the dropdown.With this change these are changed into "dropup" menus, so the expand upwards.
Uh oh!
There was an error while loading.Please reload this page.
A revision of#2, which I'm reopening due to some messy merge history (master contains some force-pushes including files I also touch here.) The adjustment is to pass in a Django template variable to control when we want dropdowns to open "up".
At the bottom of the page:
At the top of the page:
It would still be nice to do this via a bootstrap upgrade and have the dropdown direction determined dynamically, but I think this is still just small enough of a change that it's worth it.