- Notifications
You must be signed in to change notification settings - Fork14
Description
Not really an important thing to address, but the fact that annotations are linked only to a mailthread and not to a commitfest entry causes some weird behaviour. As reported by Robbert Haas on Discord:
https://commitfest.postgresql.org/patch/5501/ says that "Created patch record" happened on 2025-01-11, but it also says that Ibrar Ahmed added an annotation on 2022-07-08. even if Ibrar has a time machine, being able to add an annotation to a patch record that won't be created for another 2.5 years is an impressive achievement. 🤔
This seeming time-traveling, is caused by the fact that this emailthread was part of a commitfest entry before:https://commitfest.postgresql.org/patch/3704/
And the old annotation is still present in the new commitfest entry, because there's no link to the actual cf entry from the annotation, only to the mailthread.
pgcommitfest/pgcommitfest/commitfest/models.py
Lines 417 to 435 ind5ee5a8
| classMailThreadAnnotation(models.Model): | |
| mailthread=models.ForeignKey( | |
| MailThread,null=False,blank=False,on_delete=models.CASCADE | |
| ) | |
| date=models.DateTimeField(null=False,blank=False,auto_now_add=True) | |
| user=models.ForeignKey(User,null=False,blank=False,on_delete=models.CASCADE) | |
| msgid=models.CharField(max_length=1000,null=False,blank=False) | |
| annotationtext=models.TextField(null=False,blank=False,max_length=2000) | |
| mailsubject=models.CharField(max_length=500,null=False,blank=False) | |
| maildate=models.DateTimeField(null=False,blank=False) | |
| mailauthor=models.CharField(max_length=500,null=False,blank=False) | |
| @property | |
| defuser_string(self): | |
| return"%s %s (%s)"% ( | |
| self.user.first_name, | |
| self.user.last_name, | |
| self.user.username, | |
| ) |
One thing to consider is that maybe we want to encourage people to re-open old commitfest entries instead of creating new ones, to preserve history better generally.