- Notifications
You must be signed in to change notification settings - Fork14
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:postgres/pgcommitfest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:postgres/pgcommitfest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:bootstrap5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 12commits
- 26files changed
- 2contributors
Commits on Jan 12, 2025
This adds our own custom replication between the CFbot and thecommitfest app. We currently keep the last CFbot runs in our database,in an attempt to keep the queries easy and efficient. The CFbot resultsare now shown on the overview page of each commitfest, as well as on thepage for each specific patch.
JelteF committedJan 12, 2025 Integrate previous CFbot links with new code
In previous commits (2ada851 &b6010e9) some initial links and gitcheckout instructions were added to the patch page. I received some inperson feedback at PgConf EU that those used quite some vertical spaceon the page.Now that we have a dedicated row in the table for CFbot statuses, itseems natural to integrate those previous links and checkoutinstructions into that row. Both to keep all CFbot content together, aswell as to reduce vertical space needed.To reduce the necessary space needed for the checkout instructions,these previously explicit checkout instructions have been changed tobutton that copies the required commands to the clipboard.Finally, this also makes "Needs rebase!" link to CFbot logs instead ofCI results. I updated these logs recently on the CFbot side to becomemuch more useful to look at, by making them actually show the conflicts.
JelteF committedJan 12, 2025 Make CFbot add a history item when patch needs rebase
This is needed to send notifications to a patch author that itsubscribed. We don't send updates to other subscribers to the patch, asthis information is generally only useful for the author themselves.By using the "history item" infrastructure it's also displayed on thepatch page in the "History" table. That seems quite useful too, becauseit makes it clear how long the patch has needed a rebase.
JelteF committedJan 12, 2025 Use target=_blank for all cfbot links
JelteF committedJan 12, 2025 This is mostly useful to avoid people from adding trailing whitespace tofiles.
JelteF committedJan 12, 2025
Commits on Jan 13, 2025
Add ID column to commitfest page
The ID of a CF entry is the only stable identifier (people can changethe name). That's why tooling such as CFbot uses the ID of the patch fora lot of things (including showing it on the cfbot overview page).Having it visible on the page is quite useful for debugging purposesIneee60a5 the ID was added to the title of the entry, but that made thethe title of the page itself less prominent. So this is an attempt tohave the information available, but not too prominently visible.
JelteF committedJan 13, 2025 If the commitfest entries are sorted by a column clicking the headeragain will now remove the sort. In a future commit, it would be nice toalso support for reverse sorting.
JelteF committedJan 13, 2025 It was pretty confusing that clicking the patch name header would sortby created time, grouped by topic. This makes that sort by name.
JelteF committedJan 13, 2025 Allow sorting using the header of the closed patches too
Sorting order impacts closed patches too. So not showing the arrow thatindicates sort direction on that header is confusing. While we're at it,we might as well allow people to toggle sorting direction using thatheader too.This also automatically fixes the problem that the cell in the closedpatches header did not contain any title at all.
JelteF committedJan 13, 2025 Update readme with correct django version
JelteF committedJan 13, 2025 Make /patch/{id} the URL for a patch
Previously we'd include the ID of the commitfest in the URL of thepatch. In9f12a5e we introduced a stable URL for patches that wouldredirect to the one for the latest commitfest. This starts to use thatURL as the valid only URL for a patch (with the previous URL redirectingto this one).The reasoning behind this is that the old approach resulted in Ndifferent URLs for each patch, which all showed the exact same patchinformation. The only difference between all these URLs would be thebreadcrumb at the top of the page.The only benefit of that approach is that if you're on an oldcommitfest, and click a link there, then the breadcrumb will bring youback to where you came from. Since people rarely have a reason to browseclosed commitfests, the that benefit seems pretty small. Especiallybecause people can just as well press their browser back button, in thatcase.The problems that these N links cause seem much more impactful to mostusers:1. If you click an old link to a cf entry (e.g. one in the email archives), then the breadcrumb will contain some arbitrarily old commitfest. It seems much more useful to have the breadcrumb show the commitfest that the patch is currently active in (or got committed/rejected in).2. Places that use the stable URLs require an extra round-trip to actually get to the patch page.3. It's a bit confusing that old pages of a patch still get updated with all the new information, i.e. why have all these pages if they contain the exact same content.4. Problem 3 is generally also bad for Search Engine Optimization (SEO), for now we don't care much about that though.Finally this also changes the links on the patch page itself for each ofthe commitfests that a patch has been part of. Those links were alreadyrather useless, since all they effectively did was change thebreadcrumb. But with this new commit, they wouldn't even do that anymore,and simply redirect to the current page. So now they start pointing tothe commitfest itself, which seems more useful behaviour anyway.
JelteF committedJan 13, 2025 - JelteF committed
Jan 13, 2025
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff main...bootstrap5
Uh oh!
There was an error while loading.Please reload this page.