Commitf9c38e3

committed

fix(dropdown): corrige fluxo de encerramento e restaura foco

Evita chamadas indevidas de close no popup e garante que o focoretorne ao elemento do dropdown após o fechamento. Torna o método`hideDropdown` acessível a subclasses e adiciona listener defechamento `(p-close)="hideDropdown()"` no template para manter oestado consistente.Fixes DTHFUI-11656

1 parentdf3ba1d commitf9c38e3Copy full SHA for f9c38e3

File tree

3 files changed

+14

-3

lines changed

projects/ui/src/lib/components/po-dropdown

3 files changed

+14

-3

lines changed

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.html‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,5 +26,6 @@`
`26`	`26`	`[p-custom-positions]="['bottom-left', 'top-left']"`
`27`	`27`	`[p-size]="size"`
`28`	`28`	`[p-target]="dropdownRef"`
	`29`	`+(p-close)="hideDropdown()"`
`29`	`30`	`>`
`30`	`31`	`</po-popup>`

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.spec.ts‎`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,13 @@ describe('PoDropdownComponent: ', () => {`
`129`	`129`	`icon:undefined,`
`130`	`130`	`removeListeners:jasmine.createSpy('removeListeners'),`
`131`	`131`	`popupRef:{`
`132`		`-close:jasmine.createSpy('close')`
	`132`	`+close:jasmine.createSpy('close'),`
	`133`	`+showPopup:true`
	`134`	`+},`
	`135`	`+dropdownRef:{`
	`136`	`+nativeElement:{`
	`137`	`+focus:jasmine.createSpy('focus')`
	`138`	`+}`
`133`	`139`	`},`
`134`	`140`	`open:undefined,`
`135`	`141`	`changeDetector:{`
`@@ -142,6 +148,7 @@ describe('PoDropdownComponent: ', () => {`
`142`	`148`	`expect(fakeThis.icon).toBe('ICON_ARROW_DOWN');`
`143`	`149`	`expect(fakeThis.removeListeners).toHaveBeenCalled();`
`144`	`150`	`expect(fakeThis.popupRef.close).toHaveBeenCalled();`
	`151`	`+expect(fakeThis.dropdownRef.nativeElement.focus).toHaveBeenCalled();`
`145`	`152`	`expect(fakeThis.open).toBe(false);`
`146`	`153`	`expect(fakeThis.changeDetector.detectChanges).toHaveBeenCalled();`
`147`	`154`	`});`

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.ts‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,13 @@ export class PoDropdownComponent extends PoDropdownBaseComponent {`
`60`	`60`	`returnthis.dropdownRef&&this.dropdownRef.nativeElement.contains(event.target);`
`61`	`61`	`}`
`62`	`62`
`63`		`-privatehideDropdown(){`
	`63`	`+protectedhideDropdown(){`
`64`	`64`	`this.icon='ICON_ARROW_DOWN';`
`65`	`65`	`this.removeListeners();`
`66`		`-this.popupRef.close();`
	`66`	`+if(this.popupRef.showPopup){`
	`67`	`+this.popupRef.close();`
	`68`	`+}`
	`69`	`+this.dropdownRef.nativeElement.focus();`
`67`	`70`	`this.open=false;`
`68`	`71`	`this.changeDetector.detectChanges();`
`69`	`72`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf9c38e3

File tree

3 files changed

3 files changed

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.html‎`

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.spec.ts‎`

`‎projects/ui/src/lib/components/po-dropdown/po-dropdown.component.ts‎`

0 commit comments