Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork700
chore(imports): update the imports declarations of type annotations and declarations toimport type#606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…nd declarations to `import type`
vercelbot commentedJul 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/pmndrs/jotai/FRyxyWfEzW433iqM1LFQd4FrPdrB |
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit1e36c08:
|
dai-shi commentedJul 20, 2021
This would be just a preference, but it helps to me to understand dependencies across bundles. So, it might not be really necessary, but make things consistent. |
dai-shi commentedJul 20, 2021
I also confirmed, tsconfig change doesn't affect bundles. |
dai-shi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the work. Much appreciated.
Yeah, it's not 100% certain if we can continue the style in the future.
For now, it looks good to me. (examples may not work with old TS, but let's hope no one complain.)
liby commentedJul 20, 2021
I see what you mean.
That's alright, glad to help!
If there are any problems in the future, let's communicate at that time to see how to modify them. |
To be honest, when I was doing this PR, I saw a lot of related issues and pull.
e.g.:
Now I am beginning to think, is this really necessary?