Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(imports): update the imports declarations of type annotations and declarations toimport type#606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dai-shi merged 1 commit intopmndrs:masterfromliby:master
Jul 20, 2021

Conversation

@liby
Copy link
Contributor

@vercel
Copy link

vercelbot commentedJul 20, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/pmndrs/jotai/FRyxyWfEzW433iqM1LFQd4FrPdrB
✅ Preview:https://jotai-git-fork-liby-master-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit1e36c08:

SandboxSource
ReactConfiguration
React TypescriptConfiguration

@dai-shi
Copy link
Member

is this really necessary?

This would be just a preference, but it helps to me to understand dependencies across bundles. So, it might not be really necessary, but make things consistent.

@dai-shi
Copy link
Member

I also confirmed, tsconfig change doesn't affect bundles.

$ git diff tsconfig.jsondiff --git a/tsconfig.json b/tsconfig.jsonindex 9f5dd48..3f3d107 100644--- a/tsconfig.json+++ b/tsconfig.json@@ -2,7 +2,7 @@   "compilerOptions": {     "target": "es2019",     "strict": true,-    "jsx": "preserve",+    "jsx": "react-jsx",     "allowSyntheticDefaultImports": true,     "esModuleInterop": true,     "moduleResolution": "node",$ diff -r dist.jsx_preserve dist.jsx_react-jsx$

Copy link
Member

@dai-shidai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the work. Much appreciated.
Yeah, it's not 100% certain if we can continue the style in the future.
For now, it looks good to me. (examples may not work with old TS, but let's hope no one complain.)

liby reacted with heart emoji
@dai-shidai-shi merged commitafa0a34 intopmndrs:masterJul 20, 2021
@liby
Copy link
ContributorAuthor

This would be just a preference, but it helps to me to understand dependencies across bundles. So, it might not be really necessary, but make things consistent.

I see what you mean.

Thanks for the work. Much appreciated.

That's alright, glad to help!

For now, it looks good to me. (examples may not work with old TS, but let's hope no one complain.)

If there are any problems in the future, let's communicate at that time to see how to modify them.

dai-shi reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dai-shidai-shidai-shi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liby@dai-shi

[8]ページ先頭

©2009-2025 Movatter.jp